{{ message }}
Add GDShader#7071
Merged
Merged
Conversation
lildude
requested changes
Oct 2, 2024
lildude
left a comment
Member
There was a problem hiding this comment.
We can't accept an unlicensed grammar. All grammars must have a licence and it must be one of these to be accepted:
linguist/vendor/licenses/config.yml
Lines 4 to 15 in 9b1023e
Contributor
Author
|
Ok, I removed https://github.com/godotengine/godot-vscode-plugin Also supports GDShader (and GDScript) and has the MIT license - but it seems like this grammar is already included in the project, so I can't add it |
lildude
requested changes
Nov 25, 2024
lildude
left a comment
Member
There was a problem hiding this comment.
Please remove the vendor/grammars/SublimeGodot submodule. We don't need it.
Member
|
The PR is good to go but I can't merge it whilst it still has the unneeded |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Adds support for GDShader / Godot Shading Language. Will close the issue I made for it: #7067
GDShader is the shading language used for Godot Engine https://godotengine.org/
It is very similar to GLSL https://docs.godotengine.org/en/stable/tutorials/shaders/shader_reference/shading_language.html
This language has been known by the community as both GDShader and Godot Shading Language, as it lacked a true name. This problem was solved and it is officially being known as GDShader. (see godotengine/godot-proposals#10784)
Checklist:
In same order of sources:
#478CBF#355570, so I didn't want to use an exact same color. I was thinking from the start to differentiate them I would still use a shade of Godot blue, but lighter. So I went and color-picked the Godot Engine logo and it was the perfect color - still a Godot color but enough to differentiate from GDScript files.