{{ message }}
Update number of acceptable classification errors.#7026
Merged
Conversation
Contributor
Author
lildude
approved these changes
Sep 3, 2024
lildude
left a comment
lildude
left a comment
Member
There was a problem hiding this comment.
Whoops. I forgot about those. Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With the introduciton of the new classifier (#5103), the number of classification errors went from 19 to 14. 🎉
Number of errors (14) is within the acceptable threshold (19)https://github.com/github-linguist/linguist/actions/runs/10663397934/job/29552498132?pr=7021
This means we have to change the threshold number to 14, otherwise it won't catch new errors that could be introduced in new PRs.
Checklist:
N/A