{{ message }}
Replace mcfunction grammar#6916
Merged
Merged
Conversation
Mohdhafez86
approved these changes
Jul 7, 2024
Mohdhafez86
approved these changes
Jul 7, 2024
lildude
changed the title
language-mcfunction -> syntax-mcfunction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm replacing the grammar for
mcfunction(introduced in #4425 by @Arcensoth) fromlanguage-mcfunctiontosyntax-mcfunction.Description
syntax-mcfunctionis a new grammar written from scratch to support the newer features of Minecraft commands in newer versions of the game. This grammar was actually a prototype of a rework that Arcensoth and I planned on working together on. Unfortuntely, Arcensoth unexpectedly passed away. This grammar is now in theMinecraftCommandsorg so that it's easier to get more contributors from the community (atm, I'm the sole maintainer).The README contains a lot of detail for how this grammar differentiates itself from the original but the key differences are that it supports multi-line command and it lacks a lot of error highlighting to support future versions and custom commands (via mods or custom pre-processors). This is much more of a permissive highlighter which supports more of the community projects (such as bolt which can specify
.boltfiles being highlighted by the.mcfunctionlanguage via a.gitattributesfile).Checklist:
Questions
It seems like I have 1 warning related to the
sayrepo, I'm not entirely sure how to parse this so I might need some help to figure this out. Please let me know if I need to follow any other instructions from the contributing guide.