Extend `justfile` file detection by mkatychev · Pull Request #6795 · github-linguist/linguist · GitHub
Skip to content

Extend justfile file detection#6795

Merged
lildude merged 4 commits into
github-linguist:masterfrom
mkatychev:just-exted-ftdetect
Jun 7, 2024
Merged

Extend justfile file detection#6795
lildude merged 4 commits into
github-linguist:masterfrom
mkatychev:just-exted-ftdetect

Conversation

@mkatychev

@mkatychev mkatychev commented Apr 12, 2024

Copy link
Copy Markdown
Contributor

Description

Extend justfile filetype detection

As explained on the just repo quickstart:

The search for a justfile is case insensitive, so any case, like Justfile, JUSTFILE, or JuStFiLe, will work. just will also look for files with the name .justfile, in case you'd like to hide a justfile.

the ftdetect in the sactioned justfile vim plugin defines the full globmatch:
https://github.com/IndianBoy42/tree-sitter-just/blob/main/ftdetect/just.vim

Checklist:

  • I am adding a new extension to a language.

@mkatychev mkatychev requested a review from a team as a code owner April 12, 2024 15:47

@lildude lildude left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your sample is in the wrong place.

@mkatychev

mkatychev commented Jun 6, 2024

Copy link
Copy Markdown
Contributor Author

@lildude

lildude commented Jun 6, 2024

Copy link
Copy Markdown
Member

@lildude lildude left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Note: this PR will not be merged until close to when the next release is made. See here for more details.

@lildude lildude added this pull request to the merge queue Jun 7, 2024
Merged via the queue into github-linguist:master with commit 2723b1f Jun 7, 2024
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Sep 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants