Add support for Vento language by oscarotero · Pull Request #6733 · github-linguist/linguist · GitHub
Skip to content

Add support for Vento language#6733

Merged
lildude merged 18 commits into
github-linguist:mainfrom
oscarotero:master
Jun 4, 2025
Merged

Add support for Vento language#6733
lildude merged 18 commits into
github-linguist:mainfrom
oscarotero:master

Conversation

@oscarotero

@oscarotero oscarotero commented Mar 1, 2024

Copy link
Copy Markdown
Contributor

Hi. In this PR I'm adding support for Vento templates.

Description

Vento (.vto extension) is a template engine with support for Deno and Node. You can see more info in the documentation site: https://vento.js.org/

Checklist:

@oscarotero oscarotero requested a review from a team as a code owner March 1, 2024 18:47

@lildude lildude left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments. This language is also a long way from meeting our popularity requirements so won't be merged any time soon.

Comment thread lib/linguist/languages.yml Outdated
Comment thread lib/linguist/languages.yml Outdated
Comment thread samples/Vento/index.vto Outdated
Comment thread .gitmodules Outdated
Comment thread vendor/README.md Outdated
@oscarotero

Copy link
Copy Markdown
Contributor Author

@boehs

boehs commented Apr 16, 2025

Copy link
Copy Markdown

searching for path:*.vento now shows 2.3k results

@uncenter

Copy link
Copy Markdown

I think what @boehs is getting at is that number of files (2.4k is what I'm seeing) under https://github.com/search?q=path:*.vto&type=code would put Vento popular enough under what I understand to be the current requirements (#5756).

@RickCogley

Copy link
Copy Markdown

https://github.com/search?q=path:*.vto&type=code shows 2.7K now.

@lildude lildude added the Stale label Apr 25, 2025
@lildude

lildude commented Apr 25, 2025

Copy link
Copy Markdown
Member

https://github.com/search?q=path:*.vto&type=code shows 2.7K now.

Usage isn't an issue now. Lack of action on the initial review overall year ago is what is holding this PR back.

This PR has been marked as stale and will be closed if issues aren't addressed by the time of the next release.

@oscarotero oscarotero requested a review from lildude May 3, 2025 15:12
@oscarotero

Copy link
Copy Markdown
Contributor Author

@lildude I've made some changes and I think all your comments have been addressed.
Can you confirm if everything is okay?
Thank you!

@lildude lildude left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Popularity looks good however you appear to have an extra submodule and license file which we don't need. Please remove these.

@oscarotero oscarotero requested a review from lildude June 2, 2025 14:14
@oscarotero

Copy link
Copy Markdown
Contributor Author

@lildude done!

@lildude lildude removed the Stale label Jun 2, 2025
@oscarotero

Copy link
Copy Markdown
Contributor Author

@lildude I just resolved some merge conflicts. Let me know if more changes are needed.
thanks!

@lildude

lildude commented Jun 3, 2025

Copy link
Copy Markdown
Member

Re-adding the grammar using script/add-grammar by replacing it with itself should resolve these test failures.

@oscarotero

oscarotero commented Jun 3, 2025

Copy link
Copy Markdown
Contributor Author

@lildude thanks! I think it's fixed now (the tests pass in my codespace)

@lildude

lildude commented Jun 3, 2025

Copy link
Copy Markdown
Member

@lildude thanks! I think it's fixed now (the tests pass in my codespace)

🤔 the vendor/README.md file update is missing (the tests should fail in a mo). Looks like you forget to commit and push the changes to this file.

@oscarotero

Copy link
Copy Markdown
Contributor Author

@lildude The add-grammar command removed this entry in the README.md file. I added again and the tests failed, so I assumed it should be removed (here).

Do you want me to add it again?

@lildude

lildude commented Jun 3, 2025

Copy link
Copy Markdown
Member

@lildude The add-grammar command removed this entry in the README.md file. I added again and the tests failed, so I assumed it should be removed (here).

Do you want me to add it again?

Oh, I think I can see the problem… you've not set tm_scope in languages.yml.

@oscarotero

Copy link
Copy Markdown
Contributor Author

I followed the following instructions:

# tm_scope              - The TextMate scope that represents this programming
#                         language. This should match one of the scopes listed in
#                         the grammars.yml file. Use "none" if there is no grammar
#                         for this language.

What value should be there?

@lildude

lildude commented Jun 3, 2025

Copy link
Copy Markdown
Member

It’s the scopeName from the grammar which is automatically found and added to the grammars.yml file but needs to be manually set here as a repo can have more than one grammar scope as is the case here.

@oscarotero

Copy link
Copy Markdown
Contributor Author

Ok, I think it's good now 🤞

@lildude lildude changed the title Added support for Vento language Add support for Vento language Jun 4, 2025

@lildude lildude left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Important

The changes in this PR will not appear on GitHub until the next release has been made and deployed. See here for more details.

@lildude lildude added this pull request to the merge queue Jun 4, 2025
Merged via the queue into github-linguist:main with commit 5538111 Jun 4, 2025
5 checks passed
@uncenter

uncenter commented Jun 6, 2025

Copy link
Copy Markdown

Is it expected that the HTML part of the syntax highlighting isn't working? The Vento tags are now being highlighted but the rest isn't:

CleanShot 2025-06-06 at 10 44 13

@lildude

lildude commented Jun 6, 2025

Copy link
Copy Markdown
Member

Is it expected that the HTML part of the syntax highlighting isn't working? The Vento tags are now being highlighted but the rest isn't:

That would need to be a question you would need to raise with the upstream grammar.

@oscarotero

Copy link
Copy Markdown
Contributor Author

The VSCode extension correctly highlight HTML code.
The pattern for html is included here.

@lildude is this supported by GitHub or maybe there's another way to inject HTML as the top level grammar of Vento?

@DecimalTurn

Copy link
Copy Markdown
Contributor

The VSCode extension correctly highlight HTML code. The pattern for html is included here.

@oscarotero the scope used for html in the grammar you linked is text.html.derivative, it's a scope that is available in VS Code via this file, but it is not a scope available in the grammars compiled by linguist.

@oscarotero

Copy link
Copy Markdown
Contributor Author

Thanks @DecimalTurn
After inspecting the other grammars, it looks like the right scope should be text.html.basic, right?

@DecimalTurn

Copy link
Copy Markdown
Contributor

@github-linguist github-linguist locked as resolved and limited conversation to collaborators Sep 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants