Add Clue language by Markos-Th09 · Pull Request #6356 · github-linguist/linguist · GitHub
Skip to content

Add Clue language#6356

Merged
lildude merged 1 commit into
github-linguist:mainfrom
Markos-Th09:clue
Jun 2, 2025
Merged

Add Clue language#6356
lildude merged 1 commit into
github-linguist:mainfrom
Markos-Th09:clue

Conversation

@Markos-Th09

@Markos-Th09 Markos-Th09 commented Apr 3, 2023

Copy link
Copy Markdown
Contributor

Description

This PR adds the clue language to linguist.
Closes #6305

Checklist:

@Markos-Th09 Markos-Th09 requested a review from a team as a code owner April 3, 2023 04:41
Comment thread lib/linguist/languages.yml Outdated
@Markos-Th09 Markos-Th09 requested a review from Alhadis April 3, 2023 04:59
Comment thread samples/Clue/array.clue Outdated
@Alhadis Alhadis changed the title Add clue language Add Clue language Apr 3, 2023
@Markos-Th09 Markos-Th09 requested a review from Alhadis April 3, 2023 05:20

@Alhadis Alhadis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Markos-Th09 Regarding your question about "unacceptable samples", the following files appear to be fixtures for testing syntax-parsing, or an example code-snippet taken from a tutorial:

The following samples are good examples of realistic, practical uses for Clue (and ideally what you should be aiming for when selecting samples):

@Markos-Th09

Copy link
Copy Markdown
Contributor Author

Alhadis
Alhadis previously approved these changes Apr 3, 2023

@Alhadis Alhadis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These samples are much better, thanks!

lildude
lildude previously requested changes Apr 3, 2023

@lildude lildude left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't accept this grammar without a license. Please find another grammar or license your grammar with one of these licenses and add the cached license file to this PR (run bundle exec licensed cache -c vendor/licenses/config.yml once you've added a license file and pulled the latest SHA into this PR).

@Markos-Th09

Markos-Th09 commented Apr 3, 2023

Copy link
Copy Markdown
Contributor Author

We can't accept this grammar without a license. Please find another grammar or license your grammar with one of these licenses and add the cached license file to this PR (run bundle exec licensed cache -c vendor/licenses/config.yml once you've added a license file and pulled the latest SHA into this PR).

The grammar is licensed under MIT.

@lildude

lildude commented Apr 3, 2023

Copy link
Copy Markdown
Member

Usage is really low for inclusion right now too.

@lildude

lildude commented Apr 3, 2023

Copy link
Copy Markdown
Member

The grammar is licensed under MIT.

Not according to the repo:

CleanShot 2023-04-03 at 11 10 21

We need a license file.

@Markos-Th09

Copy link
Copy Markdown
Contributor Author

The grammar is licensed under MIT.

Not according to the repo:

CleanShot 2023-04-03 at 11 10 21

We need a license file.

It is intended to be licensed under MIT. I don't know what happened but I will add the license as soon as I can.

@Markos-Th09

Copy link
Copy Markdown
Contributor Author

Resolved

@Markos-Th09 Markos-Th09 requested a review from lildude April 3, 2023 11:57
@Markos-Th09 Markos-Th09 requested a review from a team as a code owner May 19, 2024 08:09
@lildude lildude dismissed their stale review July 10, 2024 09:02

Changes applied. Pending popularity.

@lildude

lildude commented Jun 2, 2025

Copy link
Copy Markdown
Member

Popularity looks good now, but the tests don't. All of these occur when the grammar is added manually and not with the script/add-grammar script as detailed in the CONTRIBUTING.md file. You should find replacing the grammar with itself will address these issues.

@Markos-Th09

Markos-Th09 commented Jun 2, 2025

Copy link
Copy Markdown
Contributor Author

Popularity looks good now, but the tests don't. All of these occur when the grammar is added manually and not with the script/add-grammar script as detailed in the CONTRIBUTING.md file. You should find replacing the grammar with itself will address these issues.

@lildude
It seems like there were issues when I initially used the script. I have now added the grammar again using the script, so hopefully the tests don't fail this time.

@Markos-Th09 Markos-Th09 force-pushed the clue branch 2 times, most recently from 3518ab4 to 78dfc57 Compare June 2, 2025 15:31
@lildude

lildude commented Jun 2, 2025

Copy link
Copy Markdown
Member

You need to update the vendor/README.md file too. It should have been updated by the script/add-grammar script. As an aside, we squash all commits when merging PRs so you don't need to worry about your commit history.

@Markos-Th09

Copy link
Copy Markdown
Contributor Author

@lildude lildude left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Important

The changes in this PR will not appear on GitHub until the next release has been made and deployed. See here for more details.

@lildude lildude added this pull request to the merge queue Jun 2, 2025
Merged via the queue into github-linguist:main with commit 669acc5 Jun 2, 2025
5 checks passed
@Markos-Th09 Markos-Th09 deleted the clue branch June 3, 2025 06:53
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Sep 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Language: Clue

3 participants