{{ message }}
Corrected the sed -i command in script/package shell script [#554]#672
Merged
Conversation
…, see comment by bazzaar]
Contributor
Author
Contributor
|
@brntbeer I seem to remember you creating the packaging script - would you have time to review this PR? 👀 |
Member
|
@bazzaar first off, welcome! thank you for this contribution. Sorry for the delay in looking into this, I'll take a look now ! 🎉 |
brntbeer
reviewed
Apr 2, 2019
Contributor
Author
|
Brent,
Hi, thanks for reviewing the PR.
Firstly, in the regex :
\s* means zero or more spaces, you could replace it with ‘ *’ if your shell doesn’t recognise \s.
I preferred to anchor the regex on the literal ‘:’ character because it occurs after the keyword on every line in the config file. And just deleted everything after it.
But your change works equally well.
Did you see my comment in the PR about the possible redundant kit subdir?
bazzaar
|
brntbeer
reviewed
Apr 2, 2019
Member
Yep, you're right. I'm taking a look at that but would prefer to address that after this PR is merged if you dont mind. that way we can have these two changes be atomic |
Co-Authored-By: bazzaar <barryfoxbat@btinternet.com>
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
In the training-kit README, a workflow is presented to create a local copy of the files to be served by a web-server. The first step of that workflow is to run
script/package, but that step fails ...This PR fixes two errors in the sed command inside script/package [ see comment by bazzaar in issue #554 ]
I subsequently ran through the corrected workflow on my local version of training-kit, and the web-served files are built and packaged successfully, and then display correctly in Firefox browser using the simple python web server.
Questions
As the sed regex didn't match the text in the
_config.yml, perhaps some change had been made to the_config.ymlfile previously, ... maybe the keywords are no longer as expected in that file? Just a thought ...hope this helps
bazzaar