Git guides a11y updates by stamat · Pull Request #1070 · github/training-kit · GitHub
Skip to content

Git guides a11y updates#1070

Merged
stamat merged 2 commits into
mainfrom
stamat/git-guides-a11y-updates
May 27, 2024
Merged

Git guides a11y updates#1070
stamat merged 2 commits into
mainfrom
stamat/git-guides-a11y-updates

Conversation

@stamat

@stamat stamat commented May 17, 2024

Copy link
Copy Markdown
Contributor

Overview

Hey there, big regards from @github/brand-engineering 👋

I'm currently updating the https://github.com/git-guides and I've stumbled on couple small accessibility violations in the guides:

  1. Missing a table heading copy
  2. Heading hierarchy violation

That is all! ✨

@stamat stamat self-assigned this May 17, 2024
@stamat stamat marked this pull request as ready for review May 17, 2024 11:37
@stamat stamat changed the title Stamat/git-guides-a11y-updates Git guides a11y updates May 17, 2024
@stamat stamat merged commit a50017c into main May 27, 2024
@stamat stamat deleted the stamat/git-guides-a11y-updates branch May 27, 2024 14:14
@GRURoot

This comment was marked as spam.

Comment thread git-guides/install-git.md

This comment was marked as spam.

Comment thread git-guides/install-git.md

This comment was marked as spam.

@amamore480 amamore480 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<title>جمعية الخير والعطاء</title> <style> body { font-family: Arial, sans-serif; direction: rtl; text-align: center; background-color: #f8f9fa; margin: 0; padding: 0; } header { background-color: #28a745; color: white; padding: 15px; font-size: 24px; } section { padding: 20px; } .btn { display: inline-block; background-color: #28a745; color: white; padding: 10px 20px; text-decoration: none; border-radius: 5px; font-size: 18px; } .btn:hover { background-color: #218838; } footer { background-color: #343a40; color: white; padding: 10px; position: fixed; width: 100%; bottom: 0; } </style>
<header>
    جمعية الخير والعطاء
</header>

<section>
    <h2>مهمتنا</h2>
    <p>نحن نساعد المحتاجين من خلال التبرعات والمبادرات الخيرية لنشر الخير في المجتمع.</p>
    <a href="#" class="btn">تبرع الآن</a>
</section>

<footer>
    &copy; 2025 جمعية الخير والعطاء | جميع الحقوق محفوظة
</footer>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants