{{ message }}
Repository navigation
feat(presets): resolve and materialize script artifacts - #4834
Open
mikamikasuki wants to merge 1 commit into
Open
mikamikasuki wants to merge 1 commit into
mikamikasuki wants to merge 1 commit into
Conversation
mnriem
added
the
triage-can-wait
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Replace-layer composition diagnostics regress, and materialization failure paths lack CLI coverage.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Adds CLI support for resolving and materializing preset scripts, addressing the consumption gap described in #4819.
Changes:
- Adds explicit artifact-kind selection and script output generation.
- Documents overwrite behavior and relative-import resolution.
- Adds script-resolution and materialization tests.
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| has_composition = layers[0]["strategy"] != "replace" and any( | ||
| layer["strategy"] != "replace" for layer in layers | ||
| ) | ||
| has_composition = any(layer["strategy"] != "replace" for layer in layers) |
Comment on lines
+62
to
+64
| if output is not None: | ||
| try: | ||
| content = resolver.resolve_content(template_name, "script") |
Collaborator
|
Please address Copilot feedback and fix test & lint errors |
Assisted-by: Codex (model: GPT-6 family, supervised)
mikamikasuki
force-pushed
the
feat/4819-script-resolution
branch
from
October 21, 2026 07:37
968c09b to
a4bca8c
Compare
|
|
||
| if output is not None: | ||
| try: | ||
| content = resolver.resolve_content(template_name, "script") |
| template_type = kind or ("command" if "." in template_name else "template") | ||
| is_command = template_type == "command" | ||
| valid_name = ( | ||
| re.fullmatch(r"[a-z0-9-]+(?:\.[a-z0-9-]+)+", template_name) |
Collaborator
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
--kind scripttospecify preset resolveand--output PATHto materialize the effective script for composed script presets. Documents output overwrite behavior and how relative imports resolve from the chosen output directory.Closes #4819.
Testing
uv run pytest -q tests/specify_cli/presets/test_command_resolve.py(12 passed)uv run pytest -q tests/specify_cli/presets/test_resolver.py(74 passed)git diff --checkAI Disclosure
Codex using the GPT-6 model family with the session-default reasoning setting, under human supervision. AI assistance generated the implementation, tests, and documentation. I reviewed the changes line by line and ran the tests listed above.