iframe-proxy

amirreza225 · 2026-06-19T12:47:17Z

Summary

update-agent-context.sh and update-agent-context.ps1 now prefer .specify/feature.json (written by /speckit-specify) over the mtime heuristic when no explicit plan_path argument is given
Falls back to most-recently-modified specs/*/plan.md only when feature.json is absent or the derived plan.md does not exist yet (e.g. /speckit-plan hasn't run yet)
Handles absolute feature_directory values in both scripts, normalizing to project-relative paths for the context file output
PowerShell implementation is PS 5.1-compatible: nested Join-Path, IsPathRooted guard (Unix Join-Path does not treat absolute ChildPaths as "wins"), and manual prefix-strip instead of GetRelativePath

AI disclosure

This PR was written with AI assistance (Claude Code). All changes were reviewed, tested, and understood by me before submission.

Manual test results

Agent: Claude Code | OS/Shell: macOS/zsh

Test plan

uv run pytest tests/extensions/test_update_agent_context_feature_json.py — 4 new bash tests pass (2 PS skipped, no pwsh on CI)
uv run pytest tests/test_agent_config_consistency.py tests/extensions/test_extension_agent_context.py — all 62 existing tests pass

Copilot

Pull request overview

This PR updates the agent-context extension’s context refresh scripts so that, when no explicit plan_path argument is provided, they derive the active plan.md from .specify/feature.json (written by /speckit-specify) and only fall back to the “most recently modified specs/*/plan.md” heuristic when that source is unavailable or not yet present. It also adds tests to validate the new feature.json-first behavior.

Changes:

Bash: Prefer .specify/feature.json to resolve the active plan.md, with mtime fallback retained.
PowerShell: Implement the same “feature.json-first, mtime-second” selection logic and normalize feature paths.
Tests: Add coverage ensuring feature.json overrides the mtime heuristic (bash + PowerShell where available).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
`extensions/agent-context/scripts/bash/update-agent-context.sh`	Uses `.specify/feature.json` to select the active plan when `plan_path` isn’t provided; retains mtime fallback.
`extensions/agent-context/scripts/powershell/update-agent-context.ps1`	Mirrors bash behavior in PowerShell, including absolute-path normalization and mtime fallback.
`tests/extensions/test_update_agent_context_feature_json.py`	Adds tests validating feature.json-first selection and stale-plan avoidance.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

mnriem

Please address Copilot feedback

amirreza225 · 2026-06-19T17:58:12Z

All three Copilot comments have been addressed in commit 80600a2:

GetRelativePath not available in PS 5.1 — replaced with a manual prefix-strip using StartsWith/Substring in both the feature.json path and the mtime fallback sections of update-agent-context.ps1.
open() missing explicit encoding — added encoding="utf-8" to the json.load(open(...)) call in the feature.json snippet in update-agent-context.sh.
No tests for absolute feature_directory — added two new bash tests:
- test_bash_absolute_feature_dir_under_project_root: absolute path under $PROJECT_ROOT → context file contains project-relative path (not machine-specific absolute)
- test_bash_absolute_feature_dir_outside_project_root: absolute path outside $PROJECT_ROOT → absolute path preserved as-is

All 70 tests pass locally.

amirreza225 · 2026-06-19T17:59:24Z

Please address Copilot feedback

Done

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Copilot

Copilot's findings

Files reviewed: 3/3 changed files
Comments generated: 2

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

mnriem

Please address Copilot feedback

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

mnriem · 2026-06-19T19:03:33Z

Please address Copilot feedback

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Copilot's findings

Files reviewed: 3/3 changed files
Comments generated: 2

mnriem · 2026-06-25T12:53:18Z

Please address Copilot feedback

…oding in PS ConvertFrom-Yaml path

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Copilot's findings

Files reviewed: 3/3 changed files
Comments generated: 1

mnriem · 2026-06-25T13:20:03Z

Please address Copilot feedback

…ckslashes

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Copilot's findings

Files reviewed: 3/3 changed files
Comments generated: 2

mnriem · 2026-06-25T13:44:46Z

Please address Copilot feedback

…on native Windows Python

Copilot

Copilot's findings

Files reviewed: 3/3 changed files
Comments generated: 1

mnriem · 2026-06-25T13:59:08Z

Please address Copilot feedback

…fore relativizing

Copilot

Copilot's findings

Files reviewed: 3/3 changed files
Comments generated: 2

…1 StrictMode compat

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

mnriem · 2026-06-25T15:16:00Z

Please address Copilot feedback

…re_directory is project root

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

amirreza225 · 2026-06-25T15:33:34Z

@mnriem Please run the checks

Copilot

Copilot's findings

Files reviewed: 3/3 changed files
Comments generated: 3

+        $Options = Get-Content -LiteralPath $ExtConfig -Raw -Encoding UTF8 | ConvertFrom-Yaml -ErrorAction Stop
    } catch {
        # fall through to Python fallback
    }


+import sys
+from pathlib import Path, PurePosixPath
+root = Path(sys.argv[1]).resolve()


+import sys
+from pathlib import Path, PurePosixPath
+root = Path(sys.argv[1]).resolve()


mnriem · 2026-06-25T15:59:31Z

Copilot AI review requested due to automatic review settings June 19, 2026 12:47

amirreza225 requested a review from mnriem as a code owner June 19, 2026 12:47

Copilot started reviewing on behalf of amirreza225 June 19, 2026 12:47 View session

Copilot AI reviewed Jun 19, 2026

View reviewed changes

Comment thread extensions/agent-context/scripts/powershell/update-agent-context.ps1

Comment thread extensions/agent-context/scripts/bash/update-agent-context.sh

Comment thread tests/extensions/test_update_agent_context_feature_json.py

mnriem requested changes Jun 19, 2026

View reviewed changes

amirreza225 requested a review from Copilot June 19, 2026 17:58

Copilot started reviewing on behalf of amirreza225 June 19, 2026 17:59 View session

Copilot AI reviewed Jun 19, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings June 19, 2026 18:07

Copilot started reviewing on behalf of amirreza225 June 19, 2026 18:07 View session

Copilot AI reviewed Jun 19, 2026

View reviewed changes

Comment thread tests/extensions/test_update_agent_context_feature_json.py Outdated

Comment thread tests/extensions/test_update_agent_context_feature_json.py Outdated

amirreza225 requested a review from mnriem June 19, 2026 18:15

mnriem requested a review from Copilot June 19, 2026 18:45

Copilot started reviewing on behalf of mnriem June 19, 2026 18:46 View session

Copilot AI reviewed Jun 19, 2026

View reviewed changes

Comment thread extensions/agent-context/scripts/bash/update-agent-context.sh

Comment thread extensions/agent-context/scripts/powershell/update-agent-context.ps1

Copilot AI review requested due to automatic review settings June 19, 2026 18:52

Copilot started reviewing on behalf of amirreza225 June 19, 2026 18:52 View session

Copilot AI reviewed Jun 19, 2026

View reviewed changes

Comment thread extensions/agent-context/scripts/powershell/update-agent-context.ps1

mnriem requested changes Jun 19, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings June 19, 2026 18:59

Copilot started reviewing on behalf of amirreza225 June 19, 2026 18:59 View session

Copilot AI reviewed Jun 19, 2026

View reviewed changes

Comment thread extensions/agent-context/scripts/powershell/update-agent-context.ps1

amirreza225 requested a review from Copilot June 19, 2026 19:05

Copilot started reviewing on behalf of amirreza225 June 19, 2026 19:05 View session

Copilot AI reviewed Jun 19, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings June 19, 2026 19:14

Copilot started reviewing on behalf of amirreza225 June 19, 2026 19:15 View session

amirreza225 requested a review from Copilot June 25, 2026 09:33

Copilot started reviewing on behalf of amirreza225 June 25, 2026 09:34 View session

Copilot AI reviewed Jun 25, 2026

amirreza225 requested a review from Copilot June 25, 2026 12:02

Copilot started reviewing on behalf of amirreza225 June 25, 2026 12:02 View session

Copilot AI reviewed Jun 25, 2026

mnriem requested a review from Copilot June 25, 2026 12:37

Copilot AI reviewed Jun 25, 2026

View reviewed changes

Comment thread extensions/agent-context/scripts/bash/update-agent-context.sh Outdated

Comment thread extensions/agent-context/scripts/powershell/update-agent-context.ps1

fix: resolve symlinks when computing relative plan path; use UTF8 enc…

d98c55e

…oding in PS ConvertFrom-Yaml path

Copilot AI reviewed Jun 25, 2026

Copilot AI reviewed Jun 25, 2026

View reviewed changes

Comment thread extensions/agent-context/scripts/bash/update-agent-context.sh

fix: use bash-side path for outside-root case to avoid WindowsPath ba…

d16e485

…ckslashes

Copilot AI reviewed Jun 25, 2026

Copilot AI reviewed Jun 25, 2026

View reviewed changes

Comment thread extensions/agent-context/scripts/bash/update-agent-context.sh Outdated

Comment thread extensions/agent-context/scripts/bash/update-agent-context.sh

fix: use .as_posix() instead of PurePosixPath() to avoid backslashes …

3c67851

…on native Windows Python

Copilot AI reviewed Jun 25, 2026

View reviewed changes

Comment thread extensions/agent-context/scripts/powershell/update-agent-context.ps1

fix: resolve ./.. segments in PS feature_directory via GetFullPath be…

91b672e

…fore relativizing

Copilot AI reviewed Jun 25, 2026

View reviewed changes

Comment thread extensions/agent-context/scripts/powershell/update-agent-context.ps1

Comment thread extensions/agent-context/scripts/powershell/update-agent-context.ps1

fix: replace $IsWindows guard with OSVersion.Platform check for PS 5.…

45cd965

…1 StrictMode compat

Copilot AI reviewed Jun 25, 2026

View reviewed changes

Comment thread extensions/agent-context/scripts/powershell/update-agent-context.ps1 Outdated

fix: guard empty relDir to avoid leading slash in PlanPath when featu…

b153b66

…re_directory is project root

Copilot AI reviewed Jun 25, 2026

View reviewed changes

Command tested	Notes
`/speckit.specify` → `/speckit.plan`	`CLAUDE.md` references the correct active feature's `plan.md`
Multi-spec repo with stale plan touched after specify	`CLAUDE.md` still points to active feature, not the stale one

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Conversation

amirreza225 commented Jun 19, 2026

Summary

AI disclosure

Manual test results

Test plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mnriem left a comment

Choose a reason for hiding this comment

Uh oh!

amirreza225 commented Jun 19, 2026

Uh oh!

amirreza225 commented Jun 19, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

mnriem left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

mnriem commented Jun 19, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings