{{ message }}
Repository navigation
feat(canvas): persist improvement actions and synchronization - #41
Open
lukasoppermann wants to merge 6 commits into
Open
lukasoppermann wants to merge 6 commits into
lukasoppermann wants to merge 6 commits into
Conversation
Extract the local improvement runtime, guarded actions, immutable batches and Hub synchronization from the frozen Pick & polish source. Keep renderer changes for the next layer. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9f678139-aaa7-4c9a-90a4-2f091027b85c
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved synchronization and batch-state defects can reject valid work or apply stale results.
9 open issues
What changed in this PR
Adds persistent Pick & polish requests to the canvas extension, building on Hub’s note API without introducing a new interface.
Changes:
- Store private note threads and author snapshots across reloads.
- Add guarded synchronization and immutable Copilot work batches.
- Bundle shared anchor validation and add regression coverage.
Review effort: Max
Reserve serialized answers, preserve unattributed originals, invalidate retried batch requests, isolate per-note sync conflicts and traverse complete paginated collections before synchronizing. Keep canonical anchor geometry and explicit URL reopen semantics. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9f678139-aaa7-4c9a-90a4-2f091027b85c
Merge the updated lower-layer contracts to resolve the reported PR base conflict and validate the runtime against bounded collection reads and historical owner snapshots. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9f678139-aaa7-4c9a-90a4-2f091027b85c
Merge shipped main fixes while retaining both the protected-note persistence regression and publishing-failure regression at their shared insertion point. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9f678139-aaa7-4c9a-90a4-2f091027b85c
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Capture source before target selection and require a matching successful published Build. Save the initial Build before dispatching an upload and retain it for later changes. Minify the generated anchor validator through the existing Vite build. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Pick & polish needs to retain authors' requests across canvas reloads and pass only explicitly selected work to Copilot. This is the second extraction from #13, built on the Hub persistence contracts in #39.
What changes
The extension stores notes in private local files, preserves conversation history and saved author identity, and synchronizes revisions with Hub without registering or publishing a prototype. Guarded HTTP and canvas actions reject stale checkout, account and note state. Explicit legacy ownership claims retain an audit rather than attributing older notes automatically.
Clients capture the local source before selecting a target. New notes stay local until a successful published Build matches that exact source and was published after the note was saved. Capture failures and older notes without provenance remain usable locally, with an explicit synchronization limitation. The client saves the chosen Build before its first upload, so an uncertain result or restart cannot bind another Build; follow-ups, status changes and deletion retain it.
Explicit fix requests save immutable batches before handing work to Copilot. Results update only captured requests still awaiting answers and return a bounded acknowledgment; later follow-ups remain separate work. Existing format-2 stores, version-1 threads and older Hub capability limits remain supported. The anchor validator is generated from readable Hub source and minified with the existing Vite pipeline used by the preview bridge and Controls validator. Renderer, selection bridge and visible UI changes remain in #42; this PR does not enable a new canvas interface.