{{ message }}
Repository navigation
fix(Go.gitignore): replace broad coverage.* glob with explicit coverage artifacts - #4925
Open
ashwingopalsamy wants to merge 1 commit into
Open
ashwingopalsamy wants to merge 1 commit into
ashwingopalsamy wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
coverage.*(added in #4565, my PR) is too broad. #4776 patched one case with!coverage.go, but the glob still silently ignores files that belong in a Go repo:api/coverage.pb.go,api/coverage.proto.github/workflows/coverage.ymlscripts/coverage.sh,coverage.mdVerified with
git check-ignore -vagainst currentmain.This replaces the glob (and the
!coverage.goexception) with the coverage artifacts Go tooling actually writes:coverage.out→ already covered by*.outcoverage.txt→ Codecov's Go conventioncoverage.html→go tool cover -html=… -o coverage.htmlcoverage.xml→ gocover-cobertura output*.coverprofile,profile.cov→ unchangedTrade-off: a coverage file with an unusual name now shows up in
git status(visible, easy to add locally) instead of source/config files disappearing silently.Links to documentation supporting these rule changes
If this is a new template
N/A, this changes an existing template.
Merge and Approval Steps