{{ message }}
This repository was archived by the owner on Jan 31, 2019. It is now read-only.
Update Web service to listen to all events - #712
Closed
elskwid wants to merge 1 commit into
Closed
Conversation
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
This updates
Services::Webto listen to all system events by default to bring the expected behavior in line with the documentation. From the repo hooks docs (emphasis mine):In testing with RequestBin we found the actual behavior of the web service to only listen for
pushevents. This observation is backed up with the JSON hook representation (seen below), where the only event listed ispush:{ name: "web", events: [ "push" ], supported_events: [ "commit_comment", "create", "delete", "download", "follow", "fork", "fork_apply", "gist", "gollum", "issue_comment", "issues", "member", "public", "pull_request", "pull_request_review_comment", "push", "status", "team_add", "watch" ], schema: [ [ "string", "url" ], [ "string", "secret" ], [ "string", "content_type" ], [ "string", "ssl_version" ], [ "boolean", "insecure_ssl" ] ] }Fix
Added
Service::ALL_EVENTSas thedefault_eventsso the web services would listen for all supported events.Tests
Expanded test coverage for the types of events that are listened to and a single test for an event other than
push.Service::ALL_EVENTSto thedefault_eventsissuetest to make sure the payload comes through as expected.