{{ message }}
fix(pullrequests): default mergeMethod to 'merge' when not provided#2370
Open
Will-hxw wants to merge 1 commit intogithub:mainfrom
Open
fix(pullrequests): default mergeMethod to 'merge' when not provided#2370Will-hxw wants to merge 1 commit intogithub:mainfrom
Will-hxw wants to merge 1 commit intogithub:mainfrom
Conversation
…ided When merge_method is not provided, default to 'merge' instead of passing an empty string to the GitHub API, which could cause the 405 'Merge commits are not allowed' error on repos with squash/rebase only settings. Closes github#2258
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
merge_pull_requesttool ignoresmergeMethodparametermerge_methodis not provided, default to"merge"instead of passing empty string to GitHub APIProblem
When calling
merge_pull_requestwithout providingmerge_method, the code was passing an empty string to the GitHub API, which could cause 405 errors on repositories that have disabled merge commits.Solution
Added a default value check: if
mergeMethodis empty string, set it to"merge".Validation
go build ./...passesgo test ./pkg/github/... -run "Merge|PullRequest"passes🤖 Generated with Claude Code
Fixes #2258