{{ message }}
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
A PR to add an IOLogger for logging stdin and stdout between the client and server for debugging purposes.
- Introduces an IOLogger struct with Read and Write methods that log data.
- Adds tests in pkg/log/io_test.go to verify logged IO behavior.
- Updates the server startup in cmd/server/main.go to conditionally wrap standard IO with the IOLogger based on a new command flag.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- go.mod: Language not supported
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
juruen
force-pushed
the
juruen/iologging
branch
from
2386301 to
6d63777
Compare
SamMorrowDrums
approved these changes
Mar 17, 2025
Collaborator
SamMorrowDrums
left a comment
SamMorrowDrums
left a comment
There was a problem hiding this comment.
I can see how this would save a lot of pain when iterating on things.
DaleSeo
pushed a commit
to DaleSeo/github-mcp-server
that referenced
this pull request
Oct 24, 2025
SamMorrowDrums
added a commit
that referenced
this pull request
Feb 18, 2026
Pin all three Dockerfile base images to their SHA256 digests to resolve code scanning alerts for unpinned Docker images. Dependabot docker ecosystem is already configured and will keep these digests up to date. - node:20-alpine (alert #14) - golang:1.25.7-alpine (alert #15) - gcr.io/distroless/base-debian12 (proactive) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
SamMorrowDrums
added a commit
that referenced
this pull request
Feb 18, 2026
Pin all three Dockerfile base images to their SHA256 digests to resolve code scanning alerts for unpinned Docker images. Dependabot docker ecosystem is already configured and will keep these digests up to date. - node:20-alpine (alert #14) - golang:1.25.7-alpine (alert #15) - gcr.io/distroless/base-debian12 (proactive) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR introduces an
IOLoggerstruct that logs allstdinandstdoutinteractions between the client and the server.This feature is particularly useful for debugging, as it provides visibility into the exact input and output exchanged between the client and the server.
By default, logging is disabled but can be enabled by setting the
enable-command-loggingflag totrue. I considered enabling it only when the log level is set todebug, but decided that having a separate toggle would be preferable due to potential privacy concerns.