Fix incorrect normal orientation in stl file by 8-prime · Pull Request #68 · github/gh-skyline · GitHub
Skip to content

Fix incorrect normal orientation in stl file#68

Merged
chrisreddington merged 1 commit into
github:mainfrom
8-prime:fix-normals-orientation
Jan 14, 2025
Merged

Fix incorrect normal orientation in stl file#68
chrisreddington merged 1 commit into
github:mainfrom
8-prime:fix-normals-orientation

Conversation

@8-prime

@8-prime 8-prime commented Jan 14, 2025

Copy link
Copy Markdown
Contributor

This fixes a bug where the normals in the generated stl file would be flipped. This was caused by an incorrect vertex ordering in the quad generation.
Resolves issue #67

@chrisreddington chrisreddington merged commit e88e606 into github:main Jan 14, 2025

@SoeAung95 SoeAung95 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Bug]: Incorrect normal orientation for faces in generated STL file

3 participants