{{ message }}
Refactor client to consistently use GraphQL API. Refactor tests#47
Merged
Conversation
…utilities to consolidate duplication in tests
chrisreddington
changed the title
There was a problem hiding this comment.
Copilot reviewed 5 out of 8 changed files in this pull request and generated 1 comment.
Files not reviewed (3)
- github/client.go: Evaluated as low risk
- github/client_test.go: Evaluated as low risk
- main.go: Evaluated as low risk
Comments suppressed due to low confidence (2)
types/types.go:42
- The removal of the 'Data' field from the ContributionsResponse struct changes the expected structure of the API response. Ensure that all parts of the code that parse this response are updated accordingly to avoid runtime errors.
Login string `json:"login"`
main_test.go:22
- The
MockBrowsershould returnm.Erronly ifm.Erris not nil to avoid returning a nil error when no error is expected.
return m.Err
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes significant changes to the
github/client.goandmain_test.gofiles to transition from using REST API calls to GraphQL queries. Additionally, it refactors the tests to use the newMockGitHubClientfrom themockspackage, reducing some duplication across both of those files.Throughout this PR, I'll also aim to do further cleanup in separating out those concerns.