{{ message }}
Repository navigation
Add support for go 1.25 - #1634
Merged
Merged
Conversation
ggilder
marked this pull request as ready for review
March 2, 2026 17:39
ggilder
requested review from
meiji163,
rashiq and
timvaillancourt
as code owners
March 2, 2026 17:39
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Go version detection logic in script/ensure-go-installed so that local/dev builds recognize Go 1.25 as a supported version (addressing issue #1629 around go1.25.x not matching the script’s regex).
Changes:
- Extend the supported Go version regex to include Go 1.25.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
SUPPORTED_GO_VERSIONS is used as a regex with grep, but the . characters in go1.2… are currently unescaped, so they match any character (not a literal dot). Consider tightening the pattern (e.g., escaping dots and optionally anchoring to go version output) and using grep -Eq for clarity/intent.
Contributor
Author
meiji163
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #1629
Description
Adds support for go 1.25