Add `Migrated` changelog event state by timvaillancourt · Pull Request #1134 · github/gh-ost · GitHub
Skip to content

Add Migrated changelog event state - #1134

Merged
6 commits merged into
masterfrom
changelog-migrated-state
Jul 8, 2022
Merged

6 commits merged into
masterfrom
changelog-migrated-state

Conversation

@timvaillancourt

@timvaillancourt timvaillancourt commented Jun 4, 2022 •

Copy link
Copy Markdown
Collaborator

Related issue: #1133

Description

This PR adds a Migrated changelog state and sets it in the .finalCleanup() stage of the migration. This state is informational-only and is used to indicate when a migration completed

This end time of a migration should be queryable via:

SELECT last_update FROM something_ghc WHERE hint='state' AND value='Migrated';
  • contributed code is using same conventions as original code
  • script/cibuild returns with no formatting errors, build errors or unit test errors.

@ghost

ghost commented Jul 7, 2022

Copy link
Copy Markdown

@ghost
ghost merged commit 4648da1 into master Jul 8, 2022
@ghost
ghost deleted the changelog-migrated-state branch July 8, 2022 09:49
RainbowDashy pushed a commit to RainbowDashy/gh-ost that referenced this pull request Jul 13, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant