{{ message }}
Closed
fix(middleware): resolve CompileToolResponseFilter/WithVars structural duplication#8602
Conversation
Copilot
AI
changed the title
[WIP] Fix duplicate code issue in jqschema.go
fix(middleware): resolve CompileToolResponseFilter/WithVars structural duplication
Jul 3, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The duplicate code analysis (#8552) flagged
CompileToolResponseFilterandCompileToolResponseFilterWithVarsininternal/middleware/jqschema.gofor sharing an identical ~20-linecache → parse → compile → store → returnbody.Resolution
The private generic helper
compileToolResponseFilterInternal[K comparable]has been extracted and both public functions now delegate to it:The generic
K comparabletype parameter lets both call sites use distinct cache key types (stringvstoolResponseFilterVarsCacheKey) while sharing a single implementation of the caching, parsing, and compilation logic.