{{ message }}
docs: add log volume mount to Docker dev examples in CONTRIBUTING.md#8501
Merged
Conversation
Copilot
AI
changed the title
[WIP] Update log volume mount in CONTRIBUTING.md
docs: add log volume mount to Docker dev examples in CONTRIBUTING.md
Jul 2, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Docker development examples in CONTRIBUTING.md to persist gateway logs outside the container by adding the default log directory volume mount, aligning the contributing guide with the documented container entrypoint behavior (run_containerized.sh) and the README quick start.
Changes:
- Added
-v /path/to/logs:/tmp/gh-aw/mcp-logsto the “Run Container” example. - Added the same log volume mount to the “Override with custom configuration” example for consistency.
Show a summary per file
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Low
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Docker run examples in
CONTRIBUTING.mdomitted the log directory volume mount, meaning developers following those commands would lose all logs when the container exits — complicating troubleshooting.Changes
CONTRIBUTING.md› "Run Container" — added-v /path/to/logs:/tmp/gh-aw/mcp-logsCONTRIBUTING.md› "Override with custom configuration" — same mount added for consistencydocker run --rm -i \ -e MCP_GATEWAY_PORT=8000 \ -e MCP_GATEWAY_DOMAIN=localhost \ -e MCP_GATEWAY_AGENT_ID=your-agent-id \ -v /var/run/docker.sock:/var/run/docker.sock \ -v /path/to/logs:/tmp/gh-aw/mcp-logs \ -p 8000:8000 \ awmg < config.jsonAligns with the README.md Quick Start and avoids the warning emitted by
run_containerized.sh'svalidate_log_directory_mount()when the log path isn't mounted.