{{ message }}
fix: remove headers from OTEL JSON stdin config (spec §4.1.3.7 v1.14.0 breaking change)#8500
Merged
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix OTEL headers field in JSON schema for compliance
fix: remove Jul 2, 2026
headers from OTEL JSON stdin config (spec §4.1.3.7 v1.14.0 breaking change)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the MCP Gateway’s JSON stdin configuration handling to match MCP Gateway Spec v1.14.0 breaking change: gateway.opentelemetry.headers is no longer accepted, and OTLP authentication headers must be provided via the OTEL_EXPORTER_OTLP_HEADERS environment variable instead (TOML tracing headers remain supported).
Changes:
- Removed
headersfrom the JSON stdin OpenTelemetry config schema and struct model so it’s rejected at schema-validation time. - Removed stdin→runtime tracing conversion/validation wiring for the removed field.
- Updated unit tests to assert
gateway.opentelemetry.headersis rejected and removed now-invalid assertions.
Show a summary per file
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 6/6 changed files
- Comments generated: 0
- Review effort level: Low
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec v1.14.0 removed
headersfrom theopentelemetryJSON stdin config. Authentication headers must now be passed exclusively viaOTEL_EXPORTER_OTLP_HEADERS. The field was still accepted and processed — this removes it.Changes
mcp-gateway-config.schema.json— removedheadersfromopentelemetryConfig;additionalProperties: falsenow rejects it at validation timeconfig_stdin.go— removedHeaders stringfromStdinOpenTelemetryConfigconfig_tracing.go— removedHeaders: otel.Headersfrom stdin→TracingConfigconvertervalidation.go— removedHeaders: gateway.OpenTelemetry.Headersfrom the stdin validation pathTest updates
TestLoadFromStdin_OpenTelemetryHeaders— flipped from assertingheaderspasses to asserting it fails schema validationTestStdinConverter_OTelConfig— removedHeadersfield from struct literal and corresponding assertion