{{ message }}
Deduplicate proxy startup logging via logger.StartupInfo#8426
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix duplicate logging in runProxy function
Deduplicate proxy startup logging via Jul 1, 2026
logger.StartupInfo
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes awmg proxy startup/shutdown logging by replacing ad-hoc dual logging (log.Printf + logger.LogInfo) with the shared logger.StartupInfo(...) helper, aligning the proxy command with the rest of internal/cmd.
Changes:
- Replaced proxy OpenTelemetry enable/disable banner logging with
logger.StartupInfo(...)so it logs to both stderr and the startup log sinks. - Replaced the “listening” startup log with
logger.StartupInfo(...)for consistent dual-output startup logging. - Updated the proxy shutdown banner to use the shared logging path (but see review comment about shutdown category).
Show a summary per file
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Low
Comment on lines
274
to
276
| func() { | ||
| log.Println("Shutting down proxy...") | ||
| logger.LogInfo("shutdown", "Proxy shutting down") | ||
| logger.StartupInfo("Shutting down proxy...") | ||
| }, |
Collaborator
|
@copilot address review feedback |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

internal/cmd/proxy.gowas still hand-rolling startup/shutdown dual logging instead of using the shared helper used elsewhere incmd. That left the proxy path inconsistent and caused the OpenTelemetry-disabled branch to skip the file-backed startup log sink.What changed
log.Printf+logger.LogInfopairs inrunProxy()withlogger.StartupInfo(...)Result
root.goRepresentative change