{{ message }}
fix: add roles: all to smoke-copilot workflow#8301
Merged
Conversation
The smoke copilot workflow was failing to activate when triggered via workflow_dispatch by github-actions[bot] because the pre_activation job checks the actor's collaborator permissions. The bot has 'none' permission level, causing the entire workflow to be skipped. Adding 'roles: all' (matching gh-aw-firewall's config) removes the pre_activation permission gate, allowing bot-triggered dispatches to proceed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the gh-aw source workflow frontmatter for the Smoke Copilot workflow so that bot-triggered workflow_dispatch runs (specifically github-actions[bot]) are no longer gated by the generated collaborator-permission pre_activation job.
Changes:
- Added
roles: allunder theon:frontmatter in.github/workflows/smoke-copilot.md. - Updated the generated lock workflow to remove the
pre_activationjob and itsneeds.*wiring from theactivationjob.
Show a summary per file
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Low
This was referenced Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The smoke copilot workflow fails to activate when triggered via
workflow_dispatchbygithub-actions[bot]. Thepre_activationjob checks the triggering actor's collaborator permissions, andgithub-actions[bot]has permission levelnone— causing the entire workflow to be skipped.See: https://github.com/github/gh-aw-mcpg/actions/runs/28383964655
Root Cause
The
smoke-copilot.mdworkflow source was missingroles: allin itson:block. Without it, the gh-aw compiler generates apre_activationjob that gates on collaborator permissions (admin,maintainer, orwrite). This isn't an issue ingh-aw-firewallbecause their smoke-copilot workflow already hasroles: all.Fix
Added
roles: allto the frontmatter, matching the pattern used ingh-aw-firewall. This removes thepre_activationpermission gate, allowing bot-triggered dispatches to proceed.