{{ message }}
[guard-coverage] Close issue dependency guard gaps in tool classification and DIFC labeling#8195
Merged
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix guard coverage gap for 2 operations
[guard-coverage] Close issue dependency guard gaps in tool classification and DIFC labeling
Jun 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR closes gaps in the GitHub guard’s coverage for issue dependency tools by (1) ensuring the mutating dependency tool is classified as read-write and (2) adding explicit DIFC label application rules (plus regression tests) so issue-dependency tools follow the same repo/issue scoping patterns as existing issue tools.
Changes:
- Classified
issue_dependency_writeas a read-write operation inREAD_WRITE_OPERATIONSand added a regression test for classification. - Added explicit
apply_tool_labelshandling forissue_dependency_readandissue_dependency_write, including issue-scoped descriptions and repo-visibility secrecy labeling. - Added focused label regression tests to compare
issue_dependency_readwithissue_read, and to validateissue_dependency_writeintegrity/secrecy/description.
Show a summary per file
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Low
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This was referenced Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The GitHub guard was missing explicit coverage for the upstream issue dependency capability, leaving one mutating tool unclassified and two issue-dependency tools without dedicated DIFC rule handling. This PR closes that gap by aligning classification and label application with existing issue-scoped behavior.
Tool classification (
tools.rs)issue_dependency_writetoREAD_WRITE_OPERATIONSso mutating dependency updates are treated as read-write operations.DIFC rule coverage (
tool_rules.rs)apply_tool_labelsarms for:issue_dependency_read: repo-visibility secrecy + issue-scoped description + private-repo baseline integrity behavior consistent with issue reads.issue_dependency_write: repo-visibility secrecy + issue-scoped description +writer_integrity(repo)for dependency mutations.Guard regression tests
issue_dependency_writeis classified as read-write (and not write-only).issue_dependency_readlabel output matchesissue_readfor equivalent inputs.issue_dependency_writeproduces writer integrity and expected issue description formatting.