{{ message }}
Refactor duplicated DIFC LabeledResource parsing in WASM guard response handling#8194
Merged
Merged
Conversation
Copilot
AI
changed the title
[WIP] Refactor duplicate code for LabeledResource field parsing
Refactor duplicated DIFC LabeledResource parsing in WASM guard response handling
Jun 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors WASM guard response parsing to eliminate duplicated DIFC LabeledResource field-extraction logic, reducing drift risk between single-resource and collection parsing paths.
Changes:
- Introduces
fillLabeledResourceFromMapto centralizedescription/secrecy/integrityextraction and default label initialization. - Updates both
parseResourceResponseandparseCollectionLabeledDatato delegate label population to the shared helper. - Adds focused unit tests to lock in helper behavior for fully-populated and missing/invalid fields.
Show a summary per file
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Low
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

internal/guard/wasm_parse.gohad duplicated logic for populatingdescription,secrecy, andintegrityondifc.LabeledResourcein both resource-level and collection-level parsing paths. In a DIFC enforcement path, this duplication increases drift risk when parsing behavior changes.Parsing logic consolidation
fillLabeledResourceFromMap(rawData map[string]any, resource *difc.LabeledResource)to centralizedescription/secrecy/integrityextraction and default label initialization.Call-site simplification
parseResourceResponseto delegate resource field population to the helper.parseCollectionLabeledDataitem-label parsing to reuse the same helper.Behavior lock-in via focused tests
TestFillLabeledResourceFromMapcases for:description,secrecy,integrity)