{{ message }}
[log] Add debug logging to config/config_stdin.go#8156
Merged
Conversation
Add 5 logStdin.Printf calls to fill gaps in the existing debug logger:
- convertStdinConfig: log effective gateway settings (port, toolTimeout,
startupTimeout) after conversion is complete
- convertStdinServerConfig: log HTTP auth configuration details (type
and effective audience) when auth is configured
- buildStdioServerConfig: log when extra Docker runtime args are added
- buildStdioServerConfig: log when entrypoint args are added
- normalizeLocalType: log server count when checking for 'local' type
The file already declared logStdin = logger.New("config:config_stdin")
but only used it in a few spots. These additions cover the key code paths
that are useful to observe when troubleshooting configuration issues.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves observability of the stdin (JSON) configuration loading/conversion pipeline by adding a few targeted logStdin.Printf debug statements in internal/config/config_stdin.go, gated by the existing config:config_stdin debug namespace (e.g., DEBUG=config:*).
Changes:
- Log resolved gateway settings (port/toolTimeout/startupTimeout) after stdin→internal conversion.
- Log HTTP server auth configuration (type + effective audience) when auth is present.
- Log counts for optional stdio server fields (extra Docker runtime args and entrypoint args) and for
"local"→"stdio"normalization processing.
Show a summary per file
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Low
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 5 targeted
logStdin.Printfcalls tointernal/config/config_stdin.goto make the stdin config loading pipeline more observable underDEBUG=config:*.Changes
The file already declared
var logStdin = logger.New("config:config_stdin")but only used it in a handful of spots. This PR fills the key gaps:convertStdinConfigconvertStdinServerConfigbuildStdioServerConfigbuildStdioServerConfignormalizeLocalType"local"type normalizationValidation
go build ./internal/config/...— cleango test ./internal/config/...— all tests pass