🤖 This PR was created by Repo Assist, an automated AI assistant.

Closes #8131

Problem

response_paths.rs defined PathLabelEntry — a struct structurally identical to the PathLabel type already defined in lib.rs (both carry path: String and labels: ResourceLabels). Because they were separate types, label_resource in lib.rs had to pay a needless allocation + copy loop to rename the type:

// lib.rs — pointless identity conversion (8 lines, allocates a new Vec)
let labeled_paths: Vec<PathLabel> = path_result
    .labeled_paths
    .into_iter()
    .map(|entry| PathLabel { path: entry.path, labels: entry.labels })
    .collect();

Additionally, the secrecy conditions in response_items.rs for PRs and issues used 3-way positive match arms that enumerated every tool except the search variant, while response_paths.rs already used the simpler negative check pattern (tool_name != "search_*").

Changes

labels/response_paths.rs

• Removed PathLabelEntry struct definition (it was identical to crate::PathLabel)
• Changed PathLabelResult.labeled_paths from Vec<PathLabelEntry> to Vec<crate::PathLabel>
• Updated all 9 push sites: PathLabelEntry { ... } → crate::PathLabel { ... }

lib.rs

• Removed the 8-line conversion loop; path_result.labeled_paths is now a zero-cost move into PathLabeledOutput
• Net: -12 lines of pure noise

labels/response_items.rs

• PRs arm secrecy: tool_name == "list_pull_requests" || tool_name == "pull_request_read" || tool_name == "get_pull_request" → tool_name != "search_pull_requests" (mirrors response_paths.rs pattern; future tool names automatically included)
• Issues arm secrecy: tool_name == "list_issues" || tool_name == "get_issue" || tool_name == "issue_read" → tool_name != "search_issues" (same motivation)
• Added clarifying comments at each site

Why This Matters

Performance (Task 8): Eliminates one Vec heap allocation and copy per label_resource response — the loop iterated every labeled path and cloned field values into a new Vec<PathLabel>. The new code is a single zero-cost ownership transfer.

Correctness/Maintainability (Task 3): The 3-way positive conditions were inconsistent with the already-established negative-check pattern in response_paths.rs. More importantly, adding a new tool name to the outer match arm (e.g., get_pull_request_v2) would silently fall through to vec![] secrecy — the negative-check pattern fixes this by defaulting to shared-repo secrecy for any non-search tool.

Test Status

• ✅ cargo test — all 534 Rust unit tests pass
• ⚠️ Go unit tests blocked (network access to proxy.golang.org forbidden in sandbox — infrastructure limitation, unrelated to these changes which are Rust-only)

network:
  allowed:
    - defaults
    - "proxy.golang.org"

Generated by Repo Assist · 186.4 AIC · ⊞ 12.2K · ◷
_{Comment /repo-assist to run again}

gh aw add githubnext/agentics/workflows/repo-assist.md@851905c06e905bf362a9f6cc54f912e3df747d55