{{ message }}
[log] Add debug logging to config validation error factories#8108
Merged
lpcox merged 2 commits intoJun 26, 2026
Conversation
Add logValidation.Printf calls to UndefinedVariable, MissingRequired, InvalidPattern, and SchemaValidationError in internal/config/validation_errors.go. These factory functions create ValidationError values for config failures. Logging at creation time makes it easier to trace which validation path triggered an error when debugging configuration issues with DEBUG=config:*. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves debuggability of configuration validation by adding logValidation.Printf debug logs inside several ValidationError factory helpers, so DEBUG=config:* output includes the specific JSON path and context that triggered the validation failure.
Changes:
- Added debug logging to
UndefinedVariable,MissingRequired,InvalidPattern, andSchemaValidationError. - Kept existing error values/formatting unchanged while increasing diagnostic context at error-construction time.
Show a summary per file
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Low
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
logValidation.Printfdebug logging to four validation error factory functions ininternal/config/validation_errors.gothat were previously silent.Changes
Added debug logging to:
UndefinedVariable— logs the JSON path and variable name when an env var reference is unresolvedMissingRequired— logs field name, server type, and JSON path when a required field is absentInvalidPattern— logs field name and value when a pattern match fails (e.g. container image, URL, mount)SchemaValidationError— logs server type and message for schema validation failuresUnsupportedTypealready had a log call;InvalidValueandUnsupportedFieldare either trivial delegates or general-purpose and left unlogged.Why
When debugging configuration issues (e.g.
DEBUG=config:*), there was no way to trace which specific validation path triggered an error. Logging at construction time provides the exact JSON path and context without any side effects on the returned error values.Validation
go test ./internal/config/...✅go vet ./internal/config/...✅go build✅