{{ message }}
Validate TOML gateway.port and cover config.example.toml#7792
Merged
Conversation
Copilot
AI
changed the title
[WIP] Review Go module BurntSushi/toml
Validate TOML Jun 19, 2026
gateway.port and cover config.example.toml
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request tightens TOML config validation to match the documented/JSON-stdin behavior by enforcing the gateway.port range only when explicitly set in TOML, and adds regression tests including a “smoke load” of the repository’s config.example.toml.
Changes:
- Validate TOML
gateway.portduringLoadFromFile(only whengateway.portis explicitly defined), rejecting values outside1-65535. - Add a focused regression test that fails on an out-of-range TOML port (
99999). - Add a test that loads
config.example.tomlto catch example/config drift.
Show a summary per file
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The TOML config path accepted out-of-range
gateway.portvalues even though the documented and JSON-stdin validation surface requires1-65535. This change brings TOML loading into parity and adds coverage for the repository’s primary example config.Config validation
gateway.portvalues outside1-65535duringLoadFromFilemd.IsDefined("gateway", "port")so defaulting behavior remains unchanged when the key is omittedRegression coverage
port = 99999config.example.tomlto catch parser/example driftBehavior