{{ message }}
[WIP] Fix Go Logger Enhancement workflow failure#7485
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds additional debug logging around the tracing OTLP fanout span exporter to help diagnose/export/shutdown behavior and backend failures.
Changes:
- Log when
newFanoutExporterbypasses fanout (single exporter) vs creates a fanout exporter. - Log fanout export start, per-backend export errors, and a failure summary.
- Log fanout shutdown start, per-backend shutdown errors, and completion status.
Show a summary per file
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 2
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Collaborator
|
@copilot resolve the merge conflicts in this pull request |
Adapt debug logging to the refactored forEachExporter helper introduced in main (Refactor fanout exporter concurrent dispatch #7486). The op string parameter to forEachExporter carries operation context into per-backend error log messages, satisfying the reviewer request to identify which exporter failed.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
internal/tracing/fanout.gousing the existinglogTracingpackage-level loggermake agent-finished