{{ message }}
Clarify strutil scope for time/duration formatting helpers#7327
Merged
Conversation
7 tasks
Copilot
AI
changed the title
[WIP] Refactor semantic function clustering analysis to remove dead code
Clarify Jun 10, 2026
strutil scope for time/duration formatting helpers
Contributor
There was a problem hiding this comment.
Pull request overview
Documents why FormatFutureTime and FormatDuration live in internal/strutil, clarifying that these helpers belong there due to their use in producing string output for logs and user-visible status messaging.
Changes:
- Added a short, focused comment in
internal/strutil/format_duration.goexplaining the package fit for time/duration formatting helpers.
Show a summary per file
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The refactor analysis identified several cleanup candidates and one remaining conceptual mismatch:
FormatFutureTime/FormatDurationlive ininternal/strutilbut the file did not explain why. This PR addresses that remaining gap by documenting package intent at the helper definition site.Scope clarification
internal/strutil/format_duration.goexplaining that these helpers belong instrutilbecause they produce string representations used by logging and user-facing status output.Behavioral impact
Example snippet