{{ message }}
ci: add race-test job to catch concurrency bugs#7228
Merged
Conversation
Copilot
AI
changed the title
[WIP] Add race-detection job to CI to catch concurrency bugs
ci: add race-test job to catch concurrency bugs
Jun 8, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Go race detection to the CI workflow to help catch concurrency issues in the gateway’s heavily goroutine/mutex-driven codepaths during normal CI runs.
Changes:
- Adds a new
race-testGitHub Actions job runningmake test-race(go test -race ...) with the same pinned action SHAs and Go cache reporting as existing Go jobs. - Keeps smoke workflows ungated by the race job to avoid slowing functional-feedback cycles.
Show a summary per file
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
Comment on lines
+159
to
+165
| race-test: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| concurrency: | ||
| group: ci-${{ github.ref }}-race-test | ||
| cancel-in-progress: true |
Collaborator
|
@copilot address review feedback and fix failing ci check https://github.com/github/gh-aw-mcpg/actions/runs/27153316085/job/80152331910?pr=7228 |
Contributor
Author
Addressed in commit
|
Collaborator
|
@copilot fix this failing ci check https://github.com/github/gh-aw-mcpg/actions/runs/27154684445/job/80154499627?pr=7228 |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make test-race(go test -race -timeout=5m ./internal/...) has existed since early development but was never wired into CI, leaving the heavily concurrent MCP Gateway (per-session goroutines, connection pool mutexes, DIFC label propagation) without race detection on every push/PR.Changes
.github/workflows/ci.yml: adds a standalonerace-testjob that runsmake test-raceon everypushandpull_request, using the same pinned action SHAs as existing jobsneeds:list of smoke jobs — race detection runs ~5–10× slower than normal tests and is a separate quality dimension from functional correctness; gating smokes on it would unnecessarily slow contributor feedback