{{ message }}
Repository navigation
lint: let allowed-labels skip boolean safe-output handlers (fixes main Go CI) - #70787
Merged
SivaKesava1 merged 2 commits intoOct 21, 2026
Merged
Conversation
`safe-outputs.create-issue: false` is valid frontmatter: it disables the handler and stops default issue creation. smoke-claude-sub-agents (#70671) uses it to stay read-only. The allowed-labels rule passed the value to policyMapping, which accepts only a mapping, so the repository lint test TestRepositoryAgenticWorkflows/smoke-claude-sub-agents.lock.yml fails on main ("AST policy lint requires a mapping at safe-outputs.create-issue"). A boolean handler has no allowed-labels to check, so skip it. Other non-mapping values (strings, numbers) are still reported as malformed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrow fix preserves other handlers’ label checks and includes focused regression coverage.
No open issues 🎉
What changed in this PR
Restores Go CI by letting the allowed-labels lint rule skip boolean safe-output handler values.
Changes:
- Skip booleans before mapping validation.
- Add coverage for all four handlers while verifying wildcard detection continues.
Review effort: Max
…lowed-labels-boolean-handler
Collaborator
Author
SivaKesava1
deleted the
sivakesava1/lint-allowed-labels-boolean-handler
branch
October 21, 2026 05:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main's Go CI has failed since #70671 merged (15d31e5375, 03:07 UTC):(For example, CGO run 39546336838. The same failure shows in open PRs'
impacted-go-tests.)Cause:
smoke-claude-sub-agents.mdusessafe-outputs.create-issue: falseto stay read-only. That's valid frontmatter: the compiler setsCreateIssuesDisabledand skips default issue creation. Theallowed-labelsrule (pkg/workflow/lint/output_policy.go) passes every handler value topolicyMapping, which accepts only a mapping or null. It's the only workflow with a top-levelcreate-issue: false; the others nest it undermissing-tool.Fix: skip a boolean handler value, which has no
allowed-labelsto check. Strings and numbers are still reported as malformed (TestAdditionalPolicyMalformedInputsis unchanged and passes).Tests:
TestAllowedLabelsRuleSkipsBooleanHandlers:trueorfalseon each of the four handlers raises no error, and another handler's wildcard is still reported.go test ./pkg/workflow/lint/passes. Without the fix,TestRepositoryAgenticWorkflowsfails onmain; with it, it passes.