{{ message }}
Repository navigation
Fix temporary-ID smoke summary comment targeting - #70748
Merged
Merged
Conversation
Allow the scheduled smoke workflow to comment on its newly declared parent, and use the canonical item_number field. Preserve comment limits and completion requirements; cover source configuration and native MCP calls for schedule and dispatch. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
Contributor
|
🧠 Matt Pocock Skills Reviewer is reviewing this pull request using Matt Pocock's engineering skills... |
Contributor
|
🔍 Design Decision Gate 🏗️ is checking for design decision records on this pull request... |
Contributor
|
🔎 PR Code Quality Reviewer is reviewing code quality for this pull request... |
Contributor
|
🔬 Test Quality Sentinel is analyzing test quality on this pull request... |
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Repository-wide comment targeting expands the workflow’s write scope and warrants human security sign-off.
1 open issue
What changed in this PR
Fixes the temporary-ID smoke workflow’s parent-summary targeting without changing engine behavior.
Changes:
- Allows explicit comment targets while preserving the two-comment limit.
- Uses canonical
item_numberin the summary payload. - Adds regression coverage and regenerates the affected lock.
| File | Description |
|---|---|
pkg/workflow/temporary_id_smoke_test.go |
Checks source targeting configuration and payload. |
actions/setup/js/safe_outputs_mcp_add_comment_constraints.test.cjs |
Tests scheduled/dispatched temporary-ID comments. |
.github/workflows/smoke-temporary-id.md |
Enables explicit targeting and corrects the payload field. |
.github/workflows/smoke-temporary-id.lock.yml |
Updates compiled targeting configuration and hashes. |
Review effort: Max
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
item_numberfield in the workflow's summary payload, and add source-configuration and native MCP regressions for temporary-ID targets.Fixes #70695
Evidence and scope
Main and the investigation checkout were at #70696 (
b2707604dd52732afa66ff7ae270bda96cf6c9fd), merged 2026-10-21 01:57:20Z. All latest scoped smoke runs predate that merge; none establishes a post-merge regression or hosted recovery.Run 39520308288 submitted its parent/sub-issue declarations, then received two
add_commenttarget errors before truthfully reporting incomplete. The current workflow still had that exact mismatch: scheduled runs have no triggering issue, but the required final comment names the newly created parent. This patch corrects only that residual workflow contract.Other reports were separated causally: #70704 and #70722 failed during side-repository checkout before agent execution; #70710 contains an unavailable-model 400; #70686 repeatedly built safe-output command strings in Python without executing them. Those do not justify broad safe-output or engine changes here.
Validation
make fmtandmake recompilecompleted; all 345 workflows compiled.daily-caveman-optimizer.lock.yml, intentionally excluded from this patch.Draft per inherited user preference.