iframe-proxy

pelikhan · 2026-10-21T01:39:31Z

Summary

Make diagnostic tool names explicitly describe their reporting intent: missing_tool becomes report_missing_tool, and missing_data becomes report_missing_data.

Use canonical names across compiler tool definitions, runtime handlers, prompts, schemas, and documentation. Accept legacy calls and recorded outputs without advertising duplicate tools, and normalize aliases before generation, registration, collection, and budget checks.
Make safe-outputs.report-missing-tool and safe-outputs.report-missing-data the canonical frontmatter keys. Keep legacy keys as deprecated aliases and add two format-preserving gh aw fix --write codemods, including correction of missing-tools. Conflicting keys require manual resolution instead of overwriting configuration.
Preserve explicit disables, import precedence, failure categories, audit fields, unchanged-message identity, and diagnostic/non-terminal behavior. Compare historical queue contracts canonically without rewriting stored Work or digests; alias-equivalent duplicate declarations fail closed.
Fix isolated runtime packaging of safe_output_names.cjs, retain a real strict-mode directive in the CLI helper, and align source-file assertions with unchanged workflow Markdown.
Merge origin/main and regenerate workflow locks with the canonical tool definitions and prompts. All 345 workflows compiled successfully; no authored .github/workflows/*.md changes were needed.

Validation

Passed build and formatting, JavaScript type checking, JavaScript lint, action shell lint, and schema freshness checks.
Passed CLI codemod/fix tests, related compiler/frontmatter/import tests, embedded runtime dependency closure, and deployed-bundle regressions.
After merging main, passed 380 focused JavaScript tests and focused Go tests covering both reported test failures, frontmatter migration, and embedded dependencies.
Latest make agent-report-progress: impacted Go tests and 2,178 JavaScript tests passed. The overall gate is still blocked by pre-existing Go lint findings in touched files; its workflow drift phase was therefore not reached. The merge playbook separately rebuilt and successfully recompiled all 345 workflows.
Scoped static security review of the packaging fix found no vulnerabilities or new external effects. No workflow runs were manually dispatched.

All seven supplied review threads were answered and resolved. Five supplied review-start notifications contained no actionable feedback and received separate linked responses.

Expose report_missing_tool and report_missing_data while accepting legacy calls, configurations, and recorded outputs. Update compiler contracts, runtime consumers, schemas, prompts, documentation, and regression coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

github-actions · 2026-10-21T01:51:35Z

github-actions · 2026-10-21T01:51:42Z

🔬 Test Quality Sentinel is analyzing test quality on this pull request...

github-actions · 2026-10-21T01:51:42Z

🔍 Design Decision Gate 🏗️ is checking for design decision records on this pull request...

github-actions · 2026-10-21T01:51:54Z

✂️ Ponytail Reviewer has started processing this pull request

github-actions · 2026-10-21T01:52:02Z

🧠 Matt Pocock Skills Reviewer is reviewing this pull request using Matt Pocock's engineering skills...

Copilot

🟡 Changes recommended

Missing runtime dependencies, legacy-compatibility regressions, and failing test assertions remain unresolved.

6 open issues

What changed in this PR

Renames gh-aw’s diagnostic tools to make their reporting purpose explicit across the compiler, runtime, schemas, and documentation.

Changes:

Advertises report_missing_tool and report_missing_data.
Adds legacy-name compatibility while preserving YAML keys and audit identifiers.
Updates diagnostic handling, prompts, documentation, and regression coverage.

File	Description
`schemas/agent-output.json`	Accepts canonical and legacy diagnostic types.
`pkg/workflow/unified_prompt_step.go`	Lists canonical diagnostic tools.
`pkg/workflow/tool_description_enhancer.go`	Renames the diagnostic constraint lookup.
`pkg/workflow/safe_outputs_validation_config.go`	Uses canonical validation keys.
`pkg/workflow/safe_outputs_tools.go`	Keeps renamed tools internal.
`pkg/workflow/safe_outputs_tools_meta_integration_test.go`	Updates metadata expectations.
`pkg/workflow/safe_outputs_tools_computation.go`	Enables canonical tool names.
`pkg/workflow/safe_outputs_max_validation.go`	Updates diagnostic validation identifiers.
`pkg/workflow/safe_outputs_handler_registry_test.go`	Updates registry expectations.
`pkg/workflow/safe_outputs_handler_registry_diagnostics.go`	Registers canonical diagnostic handlers.
`pkg/workflow/safe_outputs_default_create_issue_test.go`	Updates default-tool assertions.
`pkg/workflow/safe_outputs_config_generation_test.go`	Checks canonical configuration output.
`pkg/workflow/safe_output_validation_config_test.go`	Expects canonical validation keys.
`pkg/workflow/safe_output_handlers.go`	Separates canonical names from YAML keys.
`pkg/workflow/README.md`	Updates configuration descriptions.
`pkg/workflow/prompts/cache_memory_prompt.md`	Renames missing-data guidance.
`pkg/workflow/prompts/cache_memory_prompt_multi.md`	Updates multi-cache diagnostic guidance.
`pkg/workflow/prompts_test.go`	Updates cold-start guidance expectations.
`pkg/workflow/prompt_validation_test.go`	Checks canonical transport guidance.
`pkg/workflow/pi_safe_outputs_transport_integration_test.go`	Updates Pi prompt assertions.
`pkg/workflow/js/safe_outputs_tools.json`	Renames compiler tool definitions.
`pkg/workflow/engine_conformance_test.go`	Updates invalid-output fixtures.
`pkg/workflow/compiler_safe_outputs_config_test.go`	Checks renamed handler configuration.
`pkg/workflow/compiler_safe_outputs_config_assignment_test.go`	Updates automatic-handler expectations.
`pkg/workflow/cache_memory_prompt_test.go`	Checks renamed cache diagnostics.
`pkg/cli/workflows/test-create-pr-error-handling.md`	Updates diagnostic terminology.
`pkg/cli/workflows/test-copilot-missing-tool.md`	Renames workflow input references.
`pkg/cli/workflows/test-copilot-missing-data.md`	Uses the canonical reporting tool.
`pkg/cli/workflows/test-claude-missing-tool.md`	Renames workflow input references.
`pkg/cli/outcome_eval.go`	Skips both diagnostic spellings.
`pkg/cli/outcome_eval_test.go`	Covers canonical diagnostic exclusions.
`pkg/cli/logs_missing_tool_test.go`	Covers canonical tool reports.
`pkg/cli/logs_missing_data_test.go`	Uses canonical data-report fixtures.
`pkg/cli/logs_metrics.go`	Reads canonical and historical reports.
`docs/src/content/docs/troubleshooting/debugging.md`	Updates diagnostic and watchdog guidance.
`docs/src/content/docs/specs/safe-outputs-specification.md`	Specifies canonical names and aliases.
`docs/src/content/docs/reference/safe-outputs.md`	Documents compatibility boundaries.
`docs/src/content/docs/reference/outcomes.md`	Updates diagnostic outcome terminology.
`docs/src/content/docs/reference/glossary.md`	Updates watchdog diagnostic examples.
`docs/src/content/docs/reference/environment-variables.md`	Updates non-terminal output examples.
`docs/src/content/docs/reference/engines.md`	Updates watchdog terminology.
`docs/src/content/docs/reference/compilation-process.md`	Lists the renamed reporting type.
`docs/src/content/docs/reference/cache-memory.md`	Updates missing-data guidance.
`docs/src/content/docs/patterns/linter-factory.md`	Updates queue initialization guidance.
`docs/src/content/docs/engines/codex.md`	Updates circuit-breaker terminology.
`actions/setup/md/safe_outputs_cli_only_transport_prompt.md`	Uses canonical diagnostic guidance.
`actions/setup/md/mcp_cli_tools_with_safeoutputs_prompt.md`	Updates transport fallback guidance.
`actions/setup/md/cache_memory_prompt.md`	Renames cache-miss reporting.
`actions/setup/md/cache_memory_prompt_multi.md`	Renames multi-cache reporting.
`actions/setup/md/cache_memory_miss.md`	Updates cache warning terminology.
`actions/setup/js/work_queue_delivery.cjs`	Recognizes both diagnostic spellings.
`actions/setup/js/work_queue_claim_scope.test.cjs`	Updates diagnostic scope fixtures.
`actions/setup/js/work_queue_claim_scope.cjs`	Normalizes runtime diagnostic names.
`actions/setup/js/work_queue_claim_scope_checks.cjs`	Updates shared scope checks.
`actions/setup/js/types/safe-outputs.d.ts`	Types canonical and legacy records.
`actions/setup/js/scripts/fixtures/safeoutputs.cjs`	Accepts renamed fixture calls.
`actions/setup/js/safeoutputs_test_isolation.test.cjs`	Expects canonical permission reports.
`actions/setup/js/safeoutputs_cli.test.cjs`	Updates diagnostic CLI coverage.
`actions/setup/js/safeoutputs_cli.cjs`	Emits and classifies canonical diagnostics.
`actions/setup/js/safe_outputs_type_validation.test.cjs`	Checks schema alias definitions.
`actions/setup/js/safe_outputs_tools.json`	Renames runtime tool definitions.
`actions/setup/js/safe_outputs_tools_loader.cjs`	Normalizes loaded tool names.
`actions/setup/js/safe_outputs_mcp_server_http_dispatch.test.cjs`	Updates dispatch registration fixtures.
`actions/setup/js/safe_outputs_mcp_server_http_call_workflow.test.cjs`	Updates reusable-workflow registration fixtures.
`actions/setup/js/safe_outputs_mcp_server_defaults.test.cjs`	Updates default configuration fixtures.
`actions/setup/js/safe_outputs_config.cjs`	Normalizes legacy configuration keys.
`actions/setup/js/safe_output_type_validator.test.cjs`	Updates validation fixtures.
`actions/setup/js/safe_output_type_validator.cjs`	Normalizes validation and budget lookups.
`actions/setup/js/safe_output_names.test.cjs`	Covers aliases and canonical advertising.
`actions/setup/js/safe_output_names.cjs`	Adds shared alias normalization.
`actions/setup/js/safe_output_manifest.test.cjs`	Updates diagnostic exclusion assertions.
`actions/setup/js/safe_output_manifest.cjs`	Excludes both diagnostic spellings.
`actions/setup/js/safe_output_handler_manager.test.cjs`	Updates diagnostic collection coverage.
`actions/setup/js/safe_output_handler_manager.cjs`	Routes canonical diagnostic handlers.
`actions/setup/js/permission_denied_helpers.test.cjs`	Expects canonical permission payloads.
`actions/setup/js/permission_denied_helpers.cjs`	Emits canonical permission diagnostics.
`actions/setup/js/missing_tool.test.cjs`	Updates missing-tool handler fixtures.
`actions/setup/js/missing_tool.cjs`	Uses the canonical handler identifier.
`actions/setup/js/missing_messages_helper.cjs`	Updates its documentation terminology.
`actions/setup/js/missing_data.test.cjs`	Updates missing-data handler fixtures.
`actions/setup/js/missing_data.cjs`	Uses the canonical handler identifier.
`actions/setup/js/mcp_server_core.test.cjs`	Updates tool-name fixtures.
`actions/setup/js/mcp_server_core.cjs`	Resolves aliases for safeoutputs servers.
`actions/setup/js/log_parser_shared.test.cjs`	Updates diagnostic rendering fixtures.
`actions/setup/js/log_parser_shared.cjs`	Updates diagnostic comments only.
`actions/setup/js/load_agent_output.cjs`	Normalizes historical output records.
`actions/setup/js/handle_agent_failure.cjs`	Handles both diagnostic spellings.
`actions/setup/js/generate_safe_outputs_tools.test.cjs`	Updates generator catalog fixtures.
`actions/setup/js/fuzz_bash_command_parser_harness.test.cjs`	Updates diagnostic command vectors.
`actions/setup/js/eslint_factory_portfolio.cjs`	Uses canonical contract output types.
`actions/setup/js/daily_report_portfolio.test.cjs`	Updates report-contract expectations.
`actions/setup/js/daily_report_portfolio.cjs`	Uses canonical contract output types.
`actions/setup/js/copilot_sdk_driver.test.cjs`	Updates shell-permission fixtures.
`actions/setup/js/copilot_harness.test.cjs`	Updates harness diagnostic coverage.
`actions/setup/js/collect_ndjson_output.test.cjs`	Covers alias normalization and shared budgets.
`actions/setup/js/collect_ndjson_output.cjs`	Normalizes diagnostics before collection.
`actions/setup/js/codex_harness.test.cjs`	Updates permission-report expectations.
`actions/setup/js/claude_harness.test.cjs`	Updates permission-report expectations.
`actions/setup/js/bash_command_parser.test.cjs`	Updates diagnostic command fixtures.
`actions/setup/js/bash_command_parser_spec_vectors.json`	Updates the shared command vector.

_{Review effort: Max}

Add gh aw fix migrations to report-missing-tool and report-missing-data, preserve legacy schema aliases and import precedence, and cover formatting, conflicts, disables, and repeated fixes. Deploy the shared name normalizer in both MCP bundles and embedded parsers to fix gateway startup failures. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Normalize legacy config before generating tools, compare immutable delivery contracts using canonical aliases, preserve unmodified message identity, restore strict mode, and align the unchanged workflow-source assertion. Add focused generation, delivery, identity, and strict-mode regressions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

…piness

Recompile workflow locks from merged sources using canonical report_missing_tool and report_missing_data tool definitions and prompts. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

pelikhan · 2026-10-21T02:35:55Z

In response to this status notification: no code change is requested here; this only announces a reviewer run. There is no actionable engineering recommendation in this comment to accept or reject.

pelikhan · 2026-10-21T02:35:55Z

In response to this status notification: no code change is requested here; this only announces that the reviewer started. The substantive correctness feedback is being addressed separately.

pelikhan · 2026-10-21T02:35:55Z

In response to this status notification: no code change is requested here; this only announces test-quality analysis. The specific test regressions reported in review are being handled in their individual threads.

pelikhan · 2026-10-21T02:35:55Z

In response to this status notification: no code change is requested here; this only announces the design-decision review. There is no actionable design or ADR finding in this comment to implement.

pelikhan · 2026-10-21T02:35:55Z

In response to this status notification: no code change is requested here; this only announces the review run. The actionable review findings are being handled in their individual threads.

gh-aw-bot · 2026-10-21T02:57:39Z

@copilot address the following outstanding work in one pass:

Update this branch with the latest main using make merge-main, resolving any conflicts and preserving the intended changes.
Fix failing check build-wasm (FAILURE): https://github.com/github/gh-aw/actions/runs/39533808183/job/119005781837.
Fix failing check impacted-go-tests (FAILURE): https://github.com/github/gh-aw/actions/runs/39533808183/job/119005782122.

Push the necessary fixes, reply to each listed review thread and resolve it when addressed. Ignore feedback already answered or resolved. Use the pr-finisher skill and stop when only human review or CI remains; do not trigger CI.

Sous-chef head: fc3187a
Sous-chef work: 42e5d572d9d75b7168fe7d0aeda0717cc07e65ed240f6d299e6fec661214f1ac 8acb61a077717e3a460018aacdfde96fd489f77606cd36169e2328d9079b75bb
Sous-chef state: 4fda5c714a334c7e08ad322d89ede0636f064ac9293c550768ec39a39d4c67d1

Generated by 👨‍🍳 PR Sous Chef · pi · haiku45 · 3.15 AIC · ⌖ 10.1 AIC · ⊞ 1.1K · ◷
_{Comment /souschef to run again}

Refresh the smoke compiler golden for canonical diagnostic names and preserve generic MCP registration and calls when server metadata is absent. Cover metadata-free servers without weakening conformance assertions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

…piness Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot · 2026-10-21T03:31:20Z

@copilot address the following outstanding work in one pass:

Update this branch with the latest main using make merge-main, resolving any conflicts and preserving the intended changes....

Merged latest main via make merge-main; commit 9864e93 includes the regenerated workflow lock. The reported wasm-golden and conformance failures pass locally after the upstream fixes. No CI was triggered. The broader impacted run still shows two failures also present on origin/main, and the local progress gate is blocked by existing Go lint findings. All supplied review threads were already resolved. A maintainer must re-trigger CI for this updated HEAD.

gh-aw-bot · 2026-10-21T04:03:34Z

@copilot address the following outstanding work in one pass:

Update this branch with the latest main using make merge-main, resolving any conflicts and preserving the intended changes.

Push the necessary fixes, reply to each listed review thread and resolve it when addressed. Ignore feedback already answered or resolved. Use the pr-finisher skill and stop when only human review or CI remains; do not trigger CI.

Sous-chef head: 9864e93
Sous-chef work:
Sous-chef state: b889f1b40e1eb2f5c665a7b6cb2abc065a5908235a263cf58364f566e7655693

Generated by 👨‍🍳 PR Sous Chef · pi · haiku45 · 3.01 AIC · ⌖ 6.36 AIC · ⊞ 1.1K · ◷
_{Comment /souschef to run again}

…piness # Conflicts: # .github/workflows/smoke-claude-sub-agents.lock.yml Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot · 2026-10-21T04:25:25Z

Update remaining local workflow instructions and triage skill references to report_missing_tool and report_missing_data. Preserve failure category examples and compatibility contracts, refresh generated workflow metadata, and guard builtin and local workflow prompt bodies against legacy tool-name drift. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Sync the three instruction files documenting safe-outputs config with the report-missing-tool/report-missing-data rename (#70738, schema-confirmed deprecated aliases requiring `gh aw fix` migration). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

…#70835) Sync the three instruction files documenting safe-outputs config with the report-missing-tool/report-missing-data rename (#70738, schema-confirmed deprecated aliases requiring `gh aw fix` migration). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>

github-advanced-security AI found potential problems Oct 21, 2026

View reviewed changes

Comment thread actions/setup/js/safeoutputs_cli.cjs Outdated

pelikhan marked this pull request as ready for review October 21, 2026 01:50

Copilot AI max review requested due to automatic review settings October 21, 2026 01:50

Copilot started reviewing on behalf of pelikhan October 21, 2026 01:51

View session

Copilot AI reviewed Oct 21, 2026

View reviewed changes

pelikhan and others added 4 commits October 20, 2026 19:18

Merge remote-tracking branch 'origin/main' into pelikhan-didactic-hap…

439b6ab

…piness

Regenerate workflow locks after merging main

fc3187a

Recompile workflow locks from merged sources using canonical report_missing_tool and report_missing_data tool definitions and prompts. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

github-actions Bot mentioned this pull request Oct 21, 2026

[pr-sous-chef] [Sous-Chef] PR Review Progress - October 21 #70739

Open

Copilot started work on behalf of gh-aw-bot October 21, 2026 02:58

View session

pelikhan and others added 2 commits October 20, 2026 20:06

Merge remote-tracking branch 'origin/main' into pelikhan-didactic-hap…

ebbddd0

…piness Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Merge latest main and regenerate workflow lock

9864e93

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot finished work on behalf of gh-aw-bot October 21, 2026 03:32

Copilot AI requested a review from gh-aw-bot October 21, 2026 03:32

Copilot started work on behalf of gh-aw-bot October 21, 2026 04:04

View session

Merge remote-tracking branch 'origin/main' into pelikhan-didactic-hap…

e24bbcf

…piness # Conflicts: # .github/workflows/smoke-claude-sub-agents.lock.yml Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot finished work on behalf of gh-aw-bot October 21, 2026 04:29

pelikhan merged commit c636be2 into main Oct 21, 2026
51 checks passed

pelikhan deleted the pelikhan-didactic-happiness branch October 21, 2026 05:01

pelikhan mentioned this pull request Oct 21, 2026

Fix PR reviewer safe-output payload quoting guidance #70913

Merged

Sunbelt Computer Software

PL/B Language Development and Support

Conversation

pelikhan commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Validation

Uh oh!

Uh oh!

github-actions Bot commented Oct 21, 2026

Uh oh!

github-actions Bot commented Oct 21, 2026

Uh oh!

github-actions Bot commented Oct 21, 2026

Uh oh!

github-actions Bot commented Oct 21, 2026

Uh oh!

github-actions Bot commented Oct 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pelikhan commented Oct 21, 2026

Uh oh!

pelikhan commented Oct 21, 2026

Uh oh!

pelikhan commented Oct 21, 2026

Uh oh!

pelikhan commented Oct 21, 2026

Uh oh!

pelikhan commented Oct 21, 2026

Uh oh!

gh-aw-bot commented Oct 21, 2026

Uh oh!

Copilot AI commented Oct 21, 2026

Uh oh!

gh-aw-bot commented Oct 21, 2026

Uh oh!

Copilot AI commented Oct 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

pelikhan commented Oct 21, 2026 •

edited

Loading