{{ message }}
Repository navigation
Prevent OTLP placeholder masks from suppressing boolean job outputs - #69996
Merged
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix masking of 4-character OTLP header values in setup action
Prevent OTLP placeholder masks from suppressing boolean job outputs
Oct 18, 2026
pelikhan
marked this pull request as ready for review
October 18, 2026 21:24
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The JavaScript setup path still masks true, leaving the reported output-suppression bug unresolved.
1 open issue
What changed in this PR
Updates setup’s OTLP shell masking to protect boolean job outputs while preserving credential masking.
Changes:
- Restrict individual plain-header masks to nonnumeric values of at least eight characters.
- Add regression cases and exact mask-command assertions.
Review effort: Max
Separate setup runner-mask selection from artifact redaction, cover encoded placeholders and short auth credentials, and document the masking policy. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Masking an OTLP placeholder such as
X-No-Auth=truecauses GitHub Actions to drop outputs equal totrue, silently breaking activation, credit-guardrail, and patch-detection conditions.true, which blanks every job output equal totrue(v0.92.x regression) #69468