{{ message }}
Repository navigation
SSO: replace browser URL with actionable fix guidance - #68
Merged
Merged
Conversation
There was a problem hiding this comment.
⚠️ Not ready to approve
Scenario fixtures (e.g. test/scenarios/catalog.yml) still assert the removed “Authorize in your web browser” output and will fail / no longer validate the new guidance unless updated.
Pull request overview
Updates gh actions-lock SAML/SSO error output to show actionable remediation guidance rather than printing an SSO authorization URL (which is especially unhelpful in Codespaces), aligning the UX with gh auth’s existing SSO flow.
Changes:
- Replace terminal output of the captured SSO URL with environment-specific fix guidance (Codespaces devcontainer permissions vs
gh auth refresh). - Rework SSO fix-hint extraction in pin summary logic to emit the new guidance and remove URL parsing helper code.
- Add Codespaces detection + unit tests for the hint selection behavior.
File summaries
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 1
- Review effort level: Low
Note
Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
In Codespaces the ambient GITHUB_TOKEN cannot be SSO-authorized, so the 'Authorize in your web browser' URL was a dead end. Outside Codespaces we were reinventing cli/cli's SSO flow. Replace both paths: - Codespace: point to devcontainer permissions docs - Non-codespace: suggest 'gh auth refresh -h github.com' Removes the ssoURLRE-extracted URL display entirely — cli/cli owns that UX and we'll get it for free once this ships as a core command.
nodeselector
force-pushed
the
nodeselector-codespace-sso-guidance
branch
from
June 26, 2026 19:15
4f98f06 to
1712baf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
gh actions-lockhits a SAML/SSO error, we were showing an "Authorize in your web browser" URL -- reinventing the SSO flow that cli/cli already handles. In Codespaces this URL is a dead end because theghs_*token can't be SSO-authorized via browser anyway.Replace the URL display with targeted guidance:
gh auth refresh -h github.comwhich delegates to cli/cli's SSO flow