{{ message }}
Repository navigation
lint action: build from source with goproxy - #64
Merged
Merged
Conversation
Build gh-actions-lock from source instead of gh extension install. Avoids cross-repo token issues since the action source is already checked out. Adds goproxy OIDC setup for private Go dependencies and a token input for API calls.
There was a problem hiding this comment.
⚠️ Not ready to approve
The composite action currently has critical portability and runtime issues (expression-based input default + dependency on a non-public action) that can cause immediate failures for consumers.
Pull request overview
Updates the actions/lint composite action to run gh-actions-lock from the checked-out repository source (instead of installing it as a gh extension) and adds new inputs to support richer CI usage.
Changes:
- Build
gh-actions-lockviago buildand run the resulting binary during lint. - Add
tokenandignore-categoriesinputs and wire them into the lint invocation. - Add a
setup-goproxystep intended to support private Go dependency access.
File summaries
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 3
- Review effort level: Low
Note
Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+13
to
+16
| token: | ||
| description: GitHub token used by gh actions-lock for API calls. Defaults to github.token. | ||
| required: false | ||
| default: ${{ github.token }} |
Comment on lines
37
to
+38
| env: | ||
| GH_TOKEN: ${{ github.token }} | ||
| GH_TOKEN: ${{ inputs.token }} |
Comment on lines
+21
to
+23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build gh-actions-lock from source instead of
gh extension install. Avoids cross-repo token issues since the action source is already checked out when referenced asgithub/gh-actions-lock/actions/lint@main. Hack until this repo is public.Changes:
gh extension installwithgo buildfrom the checked-out sourcegithub/setup-goproxyfor private Go dependency accesstokeninput for API calls (defaults togithub.token)ignore-categoriesinput (from PR Add reusable relock workflow for Dependabot PRs #63)