{{ message }}
Repository navigation
Verify locked manifests in online runs that keep recorded pins - #212
Merged
Merged
Conversation
Read each locked action's manifest at its locked commit and block when a composite uses an action its lockfile entry does not record, or when the manifest is missing. Reads are batched across workflows, one request per nesting level, and skipped where this run already read the manifest live. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
A manifest that can't be read leaves its dependencies unverified, so it blocks like any unanswered check: exit 1 with retryable set in --json, and an abort behind the Dependabot proxy. Retryable is added with the same name and JSON key as the retry work that introduces it elsewhere. Locked-manifest reads carry their own GraphQL label. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
Manifest verification can reject valid actions and leave reused dependencies unchecked.
4 open issues
What changed in this PR
Adds online verification of locked action manifests so retained pins are checked for missing dependencies.
Changes:
- Traverse manifests at locked commits, batching reads by nesting level.
- Track seeded resolutions and read-only runs.
- Add verification tests and update request-count expectations and documentation.
Review effort: Max
- Accept a Dockerfile, the runner's fallback, where a locked action has no action.yml or action.yaml. - Treat any failed read as unverified, including a missing commit under a reused seed that parity never checked. - Report manifest mismatches as incomplete-lockfile, which a plain run doesn't repair, with its own label and remediation. - Walk seeded children reached through a live composite. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--verify,--no-fixand default runs now read each locked composite'saction.ymlat its locked commit and check its children are in the lockfile.incomplete-lockfileerror, fixed with--relock. A read GitHub doesn't answer is a retryable error.--relockcosts nothing extra.