Binary packaging by shlomi-noach · Pull Request #55 · github/freno · GitHub
Skip to content

Binary packaging - #55

Merged
shlomi-noach merged 6 commits into
masterfrom
fpm-packaging
Oct 9, 2017
Merged

Binary packaging#55
shlomi-noach merged 6 commits into
masterfrom
fpm-packaging

Conversation

@shlomi-noach

@shlomi-noach shlomi-noach commented Oct 9, 2017

Copy link
Copy Markdown

This PR adds a build script that created .deb and .rpm packaged for widespread distribution. Such binaries will be included on the releases page.

As example, the .deb package file includes:

# dpkg-deb -c /tmp/freno_*.deb
drwxr-xr-x 0/0               0 2017-10-09 05:34 ./
drwxr-xr-x 0/0               0 2017-10-09 05:34 ./etc/
drwxr-xr-x 0/0               0 2017-10-09 05:34 ./etc/init.d/
-rwxr-xr-x 0/0            1464 2017-10-09 05:34 ./etc/init.d/freno
-rw-r--r-- 0/0             286 2017-10-09 05:34 ./etc/freno.conf.json
drwxr-xr-x 0/0               0 2017-10-09 05:34 ./usr/
drwxr-xr-x 0/0               0 2017-10-09 05:34 ./usr/bin/
-rwxr-xr-x 0/0        11582053 2017-10-09 05:34 ./usr/bin/freno
drwxr-xr-x 0/0               0 2017-10-09 05:34 ./usr/share/
drwxr-xr-x 0/0               0 2017-10-09 05:34 ./usr/share/doc/
drwxr-xr-x 0/0               0 2017-10-09 05:34 ./usr/share/doc/freno/
-rw-r--r-- 0/0             131 2017-10-09 05:34 ./usr/share/doc/freno/changelog.gz
drwxr-xr-x 0/0               0 2017-10-09 05:34 ./var/
drwxr-xr-x 0/0               0 2017-10-09 05:34 ./var/lib/

Same for rpm:

$ rpm -qpl /tmp/freno-*.rpm
/etc/freno.conf.json
/etc/init.d/freno
/usr/bin/freno
/var/lib

Once this branch is merged we can make a public release.

@shlomi-noach
shlomi-noach requested a review from miguelff October 9, 2017 05:40
miguelff
miguelff approved these changes Oct 9, 2017
View reviewed changes

@miguelff miguelff left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

Comment thread build.sh

@miguelff miguelff Oct 9, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 to provide instructions on installing fpm.

@shlomi-noach
shlomi-noach merged commit d42d296 into master Oct 9, 2017
@shlomi-noach
shlomi-noach deleted the fpm-packaging branch October 9, 2017 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@miguelff miguelff miguelff approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shlomi-noach @miguelff