Minor formatting tweaks by Zearin · Pull Request #491 · github/developer.github.com · GitHub
Skip to content
This repository was archived by the owner on Nov 1, 2017. It is now read-only.

Minor formatting tweaks - #491

Merged
gjtorikian merged 3 commits into
github:masterfrom
Zearin:patch-3
Apr 28, 2014
Merged

gjtorikian merged 3 commits into
github:masterfrom
Zearin:patch-3

Conversation

@Zearin

@Zearin Zearin commented Apr 26, 2014

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread content/v3/repos/releases.md Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a native speaker 😬, but I believe that "...will only receive published releases" and "... will receive published releases only" have different meanings, and that the current text is correct in this case. /cc @gjtorikian

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @izuzak!

I’m a native English speaker. English is a weird language, with lots of special cases. (It’s due to its “mutt” like, hybrid nature.)

There are certainly situations in which a change like this would change the meaning of the sentence. In this case, I do not believe the meaning of this sentence changes; therefore, my edit was purely based on preferred style.

That said, after a re-read of this edit, I’ve just thought of a better way to phrase the sentence. So, hang on a moment, and I’ll have this fixed in a few! :)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rewritten with clearer phrasing in the latest commit!

@izuzak

izuzak commented Apr 28, 2014

Copy link
Copy Markdown
Member

Thanks @Zearin 📝 🍰

Other than that one comment -- this looks good to me. Would love it if @gjtorikian could take a look at these suggestions as well, though 😸

Comment thread content/v3/repos/releases.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 to rewriting it to emphasize push access over pull (as we do in other parts of the site).

It took me a while to parse what this is saying, though. How about:

Information about published releases are available to everyone. Only users with push access will receive listings for draft releases.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it better than my last edit! Will fix in a minute…

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

@gjtorikian

Copy link
Copy Markdown
Contributor

Good stuff! Really appreciate the attention to using backticks. I made one slight suggestion for the intro paragraph.

@gjtorikian

Copy link
Copy Markdown
Contributor

🍰

gjtorikian added a commit that referenced this pull request Apr 28, 2014
@gjtorikian
gjtorikian merged commit cef340e into github:master Apr 28, 2014
@Zearin

Zearin commented Apr 28, 2014

Copy link
Copy Markdown
Contributor Author

w00t w00t! 😄

@Zearin
Zearin deleted the patch-3 branch April 28, 2014 18:04
@izuzak

izuzak commented Apr 28, 2014

Copy link
Copy Markdown
Member

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants