Repository navigation
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request upgrades the repository’s CodeQL toolchain and pack dependencies (notably moving to CodeQL CLI 2.23.3 and codeql/cpp-all 6.0.0), while updating many C/C++ coding-standards queries to newer dataflow/taint-tracking and concurrency libraries. It also refreshes a large set of unit test .expected outputs and adds a change note documenting the version bump and query behavior adjustments.
Changes:
- Bump supported CodeQL environment to
2.23.3and update CodeQL pack dependencies/locks (includingcodeql/cpp-all: 6.0.0). - Migrate many queries and shared libraries from deprecated dataflow/taint-tracking/concurrency modules to
...dataflow.new...andConcurrencyNew. - Update unit tests and
.expectedfiles to reflect changed query outputs; add a change note for the upgrade.
Checklist items uncertain (not confirmed in this review):
- Shared query format validation in VS Code (per PR checklist).
- Performance/result validation on OpenPilot (per PR checklist).
Show a summary per file
Review details
Comments suppressed due to low confidence (1)
c/common/src/codingstandards/c/Extensions.qll:127
CRealTypeExtensionExtensionnow matchesFloat128Type, but the diagnostic message still says "Decimal floats". This will produce misleading results for users.
- Files reviewed: 244/244 changed files
- Comments generated: 5
- Review effort level: Low
|
🏁 Beep Boop! One or things failed during performance testing. Please check the release engineering repo for details. |
b5970a4 to
d66ec8d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
/test-performance |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Looks like performance has still regressed, with these slow predicates: |
|
/test-performance |
|
🏁 Beep Boop! Performance testing for this PR has been initiated. Please check back later for results. Note that the query package generation step must complete before testing will start so it might be a minute. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
0fcd2c4 to
f549f7a
Compare
MichaelRFairhurst
left a comment
There was a problem hiding this comment.
A few thoughts for the first round!

Description
This PR migrates queries and shared libraries from the deprecated AST-based dataflow APIs to the IR-based
semmle.code.cpp.dataflow.newimplementation.The migration updates flow configurations for use-use dataflow and standard-library models.
User-visible changes
ENV30-C, RULE-21-19, RULE-25-5-2: removes duplicate alerts for the same modification of a pointer returned by an environment or locale function.
RULE-14-3: reports invariant-false loop conditions that use the integer literal 0, including compound controlling expressions.
ARR30-C: a negative out-of-bounds access may produce a result for each buffer expression reaching that access.
ARR38-C, RULE-21-17, RULE-21-18, RULE-8-7-1: corrects strncat and wcsncat modeling. Destinations must be null-terminated, while sources need not contain a null terminator within the specified character limit.
Internal changes
Migrates direct rule queries including EXP30-C, EXP50-CPP, MEM52-CPP, MEM53-CPP, A18-1-4, RULE-0-1-1, and RULE-14-3.
Adapts path queries to the new node and access-path representations.
Change request type
.ql,.qll,.qlsor unit tests)Rules with added or modified queries
Release change checklist
A change note (development_handbook.md#change-notes) is required for any pull request which modifies:
If you are only adding new rule queries, a change note is not required.
Author: Is a change note required?
🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.
Reviewer: Confirm that either a change note is not required or the change note is required and has been added.
Query development review checklist
For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:
Author
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Reviewer
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.