Promote `AllowToolcacheInput` feature by mbg · Pull Request #4044 · github/codeql-action · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 4 additions & 18 deletions lib/entry-points.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 0 additions & 6 deletions src/feature-flags.ts
14 changes: 3 additions & 11 deletions src/setup-codeql.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,7 @@ test.serial(
async (t) => {
const loggedMessages: LoggedMessage[] = [];
const logger = getRecordingLogger(loggedMessages);
const features = createFeatures([Feature.AllowToolcacheInput]);
const features = createFeatures([]);

const latestToolcacheVersion = "3.2.1";
const latestVersionPath = "/path/to/latest";
Expand Down Expand Up @@ -580,7 +580,7 @@ const toolcacheInputFallbackMacro = makeMacro({

toolcacheInputFallbackMacro.serial(
"the toolcache doesn't have a CodeQL CLI when tools == toolcache",
[Feature.AllowToolcacheInput],
[],
{ GITHUB_EVENT_NAME: "dynamic" },
[],
[
Expand All @@ -591,22 +591,14 @@ toolcacheInputFallbackMacro.serial(

toolcacheInputFallbackMacro.serial(
"the workflow trigger is not `dynamic`",
[Feature.AllowToolcacheInput],
[],
{ GITHUB_EVENT_NAME: "pull_request" },
[],
[
`Ignoring 'tools: toolcache' because the workflow was not triggered dynamically.`,
],
);

toolcacheInputFallbackMacro.serial(
"the feature flag is not enabled",
[],
{ GITHUB_EVENT_NAME: "dynamic" },
[],
[`Ignoring 'tools: toolcache' because the feature is not enabled.`],
);

test.serial(
'tryGetTagNameFromUrl extracts the right tag name for a repo name containing "codeql-bundle"',
(t) => {
Expand Down
18 changes: 4 additions & 14 deletions src/setup-codeql.ts
Loading