Update deprecation warnings for CodeQL Action to v4 by mario-campos · Pull Request #3272 · github/codeql-action · GitHub
Skip to content

Update deprecation warnings for CodeQL Action to v4#3272

Merged
mario-campos merged 14 commits intomainfrom
mario-campos/v4-warning
Nov 5, 2025
Merged

Update deprecation warnings for CodeQL Action to v4#3272
mario-campos merged 14 commits intomainfrom
mario-campos/v4-warning

Conversation

@mario-campos
Copy link
Copy Markdown
Contributor

@mario-campos mario-campos commented Nov 4, 2025 •
edited
Loading

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

  • Advanced setup - Impacts users who have custom workflows.
  • GHES - Impacts GitHub Enterprise Server.

How did/will you validate this change?

  • Unit tests - I am depending on unit test coverage (i.e. tests in .test.ts files).
  • End-to-end tests - I am depending on PR checks (i.e. tests in pr-checks).

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Rollback - Change can only be disabled by rolling back the release or releasing a new version with a fix.

How will you know if something goes wrong after this change is released?

  • Telemetry - I rely on existing telemetry or have made changes to the telemetry.
    • Alerts - New or existing monitors will trip if something goes wrong with this change.
  • Other - Feedback

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

@github-actions github-actions Bot added the size/XS Should be very easy to review label Nov 4, 2025
@github-actions github-actions Bot added size/S Should be easy to review and removed size/XS Should be very easy to review labels Nov 4, 2025
@mario-campos
Copy link
Copy Markdown
Contributor Author

mario-campos commented Nov 4, 2025 •
edited
Loading

@mario-campos mario-campos marked this pull request as ready for review November 4, 2025 17:45
@mario-campos mario-campos requested a review from a team as a code owner November 4, 2025 17:45
Copilot AI review requested due to automatic review settings November 4, 2025 17:45
mbg
mbg reviewed Nov 4, 2025
View reviewed changes
Comment thread src/util.ts
Comment thread src/util.ts Outdated
Copilot AI reviewed Nov 4, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the CodeQL Action version deprecation warning from v3 to v4. The changes prepare users for the upcoming deprecation of CodeQL Action v3 by updating version checks, error messages, and minimum supported GHES version requirements.

  • Updates version check logic to warn users running v1, v2, or v3 to upgrade to v4
  • Changes minimum GHES version requirement from 3.11 to 3.20 for v4 support
  • Updates deprecation message and changelog URL

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

File Description
src/util.ts Updated checkActionVersion function to check for v4 instead of v3, changed GHES minimum version to 3.20, and updated deprecation message
src/util.test.ts Added test cases for v3 and v4 version checks with various GHES versions, updated expected error message
lib/*.js Generated JavaScript files reflecting the TypeScript changes (auto-generated, not reviewed per guidelines)
CHANGELOG.md Documented the new v3 to v4 migration warning

Comment thread src/util.ts Outdated
Comment thread CHANGELOG.md Outdated
henrymercer
henrymercer reviewed Nov 5, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of minor messaging suggestions.

Comment thread src/util.ts Outdated
Comment thread src/util.ts Outdated
Comment thread src/util.test.ts Outdated
Comment thread CHANGELOG.md Outdated
henrymercer
henrymercer approved these changes Nov 5, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mario-campos mario-campos merged commit 320a6b6 into main Nov 5, 2025
241 checks passed
@mario-campos mario-campos deleted the mario-campos/v4-warning branch November 5, 2025 16:01
This was referenced Nov 13, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mbg mbg mbg left review comments

Copilot code review Copilot Copilot left review comments

@henrymercer henrymercer henrymercer approved these changes

Assignees

No one assigned

Labels

size/S Should be easy to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mario-campos @mbg @henrymercer