{{ message }}
Repository navigation
Bump minimum CodeQL version to 2.10.5 - #1907
Merged
Merged
Conversation
aeisenberg
previously approved these changes
Sep 27, 2023
aeisenberg
left a comment
aeisenberg
left a comment
Contributor
There was a problem hiding this comment.
This is great.
Can you also take a look at the individual checks to see if any of them can start testing against more versions. For example, pr-checks/checks/packaging-config-inputs-js.yml says that it works against recent CLIs, but now, I think it is available in all CLIs that are still supported.
This could happen separately.
And, only if you think it would be helpful, you could add a section in the CONTRIBUTING.md on the different steps to take when removing support for an old CLI.
Contributor
Author
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the 2.9.* series is deprecated, we can remove tech debt in the Action and update our testing matrix to improve our test coverage against the latest versions of CodeQL.
Merge / deployment checklist