{{ message }}
Repository navigation
Send tools telemetry to init status report - #1497
Merged
Merged
Conversation
angelapwen
force-pushed
the
tools-telemetry-report
branch
from
January 21, 2023 00:37
a9545a6 to
f24d78c
Compare
angelapwen
changed the title
init status report
angelapwen
marked this pull request as ready for review
January 21, 2023 01:06
angelapwen
force-pushed
the
tools-telemetry-report
branch
from
January 21, 2023 01:10
a217825 to
4fa58ed
Compare
Contributor
Author
Contributor
|
I think this could be as boring as just needing to merge in main and recompile the Action — some of the compiled files seem to be missing at the moment. |
henrymercer
reviewed
Jan 23, 2023
…n/codeql-action into tools-telemetry-report
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
Author
|
I have an issue with |
angelapwen
force-pushed
the
tools-telemetry-report
branch
from
January 23, 2023 18:30
8ca90f9 to
919c531
Compare
henrymercer
reviewed
Jan 23, 2023
henrymercer
left a comment
henrymercer
left a comment
Contributor
There was a problem hiding this comment.
I like how you've used this additional telemetry information to improve the tests for setting up the CodeQL tools! Here's a couple of initial comments:
Contributor
Author
henrymercer
reviewed
Jan 24, 2023
Co-authored-by: Henry Mercer <henry.mercer@me.com>
henrymercer
previously approved these changes
Jan 25, 2023
4 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sends the following fields to the
initstatus report on success and failure:tools_sourcetools_sourcewasDOWNLOAD,tools_download_duration_msandtools_feature_flags_validNote that previously we only sent additional fields on
initsuccess, but because we would like to support the tools fields on failure as well, the PR changes the status report behavior so that theinitreport is sent on failure too, with as many fields populated as possible.Merge / deployment checklist