{{ message }}
Repository navigation
Update bundle to 2.12.0 - #1466
Merged
Merged
Conversation
dbartol
marked this pull request as draft
January 6, 2023 16:01
Contributor
Author
|
@angelapwen Thanks for the heads up! |
henrymercer
previously approved these changes
Jan 6, 2023
dbartol
marked this pull request as ready for review
January 10, 2023 14:30
dbartol
enabled auto-merge
January 10, 2023 14:30
aeisenberg
reviewed
Jan 10, 2023
Contributor
There was a problem hiding this comment.
Something minor and doesn't need to happen for this release, but perhaps we should start linking to the release notes for the CLI version we are upgrading to.
aeisenberg
previously approved these changes
Jan 10, 2023
aeisenberg
left a comment
aeisenberg
left a comment
Contributor
There was a problem hiding this comment.
To be clear...this integration test will continue to fail until it starts using a version of the CLI that supports kotlin 1.8.0?
I think that is fine, but if this gets annoying, we should disable this test in main and create an issue to remind ourselves to re-enable it.
Kotlin analysis is incompatible with Kotlin 1.8.0, which is now rolling out to the Actions runner images. While we work on a more permanent fix to our PR checks, this will prevent us losing other test coverage.
…kotlin-in-pr-checks Temporarily disable Kotlin analysis in PR checks
adityasharad
approved these changes
Jan 10, 2023
3 tasks done
This was referenced Jan 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge / deployment checklist