C#: Replace `localFlow` with `localFlowStep` in recursive predicate by hvitved · Pull Request #7122 · github/codeql · GitHub
Skip to content

C#: Replace localFlow with localFlowStep in recursive predicate#7122

Merged
hvitved merged 1 commit into
github:mainfrom
hvitved:csharp/expose-repr-perf
Nov 15, 2021
Merged

C#: Replace localFlow with localFlowStep in recursive predicate#7122
hvitved merged 1 commit into
github:mainfrom
hvitved:csharp/expose-repr-perf

Conversation

@hvitved

@hvitved hvitved commented Nov 12, 2021

Copy link
Copy Markdown
Contributor

This change avoids the computation of an expensive transitive closure:

	ExposeRepresentation.ql-32:DataFlowPublic::localExprFlow#ff .......................................................................................... 3m50s
	ExposeRepresentation.ql-32:DataFlowPublic::localExprFlow#ff_10#join_rhs .............................................................................. 2m7s

Similar to #6885.

@hvitved hvitved requested a review from a team as a code owner November 12, 2021 13:15
@github-actions github-actions Bot added the C# label Nov 12, 2021
@hvitved hvitved added the no-change-note-required This PR does not need a change note label Nov 12, 2021
@hvitved hvitved merged commit f01b900 into github:main Nov 15, 2021
@hvitved hvitved deleted the csharp/expose-repr-perf branch November 15, 2021 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C# no-change-note-required This PR does not need a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants