{{ message }}
Repository navigation
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
These tests fail until type-switch implicit variable assignments are modeled as write instructions in the next commit. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The foundational SSA/IR migration has unresolved behavior and compatibility regressions that need human validation.
3 open issues
What changed in this PR
Refactors Go’s static single-assignment (SSA) analysis to use shared CodeQL classes.
Changes:
- Migrates data-flow, control-flow, framework models, and queries to definition-based APIs.
- Adds deprecated compatibility classes and explicit type-switch write targets.
- Updates test expectations, annotation comments, and migration notes.
Review effort: Max
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Comment on lines
+143
to
147
| /** Holds if this node defines SSA definition `def` to be `rhs`. */ | ||
| predicate definesSsaDefinition(SsaDefinition def, DataFlow::Node rhs) { | ||
| super.getLhs().asSsaDefinition() = def and | ||
| super.getRhs() = rhs.asInstruction() | ||
| } |
Comment on lines
+1141
to
+1142
| /** Gets the SSA definition being written to, if any. */ | ||
| SsaDefinition asSsaDefinition() { this.getWrite() = result.(SsaExplicitWrite).getDefinition() } |
| * corresponding to `a.b`. | ||
| */ | ||
| SsaVariable getBaseVariable() { | ||
| SsaDefinition getBaseDefinition() { |
Comment on lines
+990
to
+991
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.